public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lsmod01: parse a copy of /proc/modules
Date: Mon, 29 Aug 2016 09:34:54 -0400 (EDT)	[thread overview]
Message-ID: <8140813.24444.1472477694219.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <57C43307.8000709@oracle.com>





----- Original Message -----
> From: "Stanislav Kholmanskikh" <stanislav.kholmanskikh@oracle.com>
> To: "Cyril Hrubis" <chrubis@suse.cz>
> Cc: "vasily isaenko" <vasily.isaenko@oracle.com>, ltp@lists.linux.it
> Sent: Monday, 29 August, 2016 3:05:11 PM
> Subject: Re: [LTP] [PATCH] lsmod01: parse a copy of /proc/modules
> 
> 
> 
> On 08/29/2016 03:50 PM, Cyril Hrubis wrote:
> > Hi!
> >> In my environment, if TMPDIR is on NFSv4, this test case fails with:
> >>
> >> lsmod01 1 TFAIL : lsmod output different from /proc/modules.
> >>   21c21
> >>   < sunrpc 207591 28
> >>   ---
> >>   > sunrpc 207591 29
> >>
> >> To avoid such problems I separate the process of getting data from
> >> /proc/modules and the process of parsing it in the pipe structure.
> > 
> > So the sunrpc module gets its ref counter incremented from somewhere of
> > the nfs kernel code once we open file on NFS?
> 
> Looks so. I hava a share mounted from localhost:
> 
> [root@skholman-m7 mnt]# mount|grep mnt
> 127.0.0.1:/opt on /mnt type nfs
> (rw,vers=4,addr=127.0.0.1,clientaddr=127.0.0.1)
> [root@skholman-m7 mnt]# awk '{print $1, $2, $3}' /proc/modules|sort >
> /tmp/not_nfs
> [root@skholman-m7 mnt]# awk '{print $1, $2, $3}' /proc/modules|sort > nfs
> [root@skholman-m7 mnt]# grep sunrpc nfs
> sunrpc 207591 29
> [root@skholman-m7 mnt]# grep sunrpc /tmp/not_nfs
> sunrpc 207591 28
> [root@skholman-m7 mnt]#

And if you do that with just "cat /proc/modules", then there's no difference?
Could it be that it's actually first write that takes extra ref?
cat is reading in 65536 byte chunks for me, awk only 1024.

Regards,
Jan

> 
> 
> 
> > 
> > But shouldn't the shell open the temp file the output is redirected to
> > before it executes the command line anyway?
> > 
> 
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
> 

  reply	other threads:[~2016-08-29 13:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 11:08 [LTP] [PATCH] lsmod01: parse a copy of /proc/modules Stanislav Kholmanskikh
2016-08-29 12:50 ` Cyril Hrubis
2016-08-29 13:05   ` Stanislav Kholmanskikh
2016-08-29 13:34     ` Jan Stancek [this message]
2016-08-29 14:00       ` Stanislav Kholmanskikh
2016-08-29 14:03         ` Stanislav Kholmanskikh
2016-08-29 15:17           ` Cyril Hrubis
2016-08-29 15:49           ` Jan Stancek
2016-10-11 12:03             ` Stanislav Kholmanskikh
2016-10-11 13:38               ` Cyril Hrubis
2016-10-11 15:47                 ` Stanislav Kholmanskikh
2016-10-11 16:15                   ` Cyril Hrubis
2016-11-09 14:34                     ` [LTP] [PATCH] lsmod01: keep the output in variables Stanislav Kholmanskikh
2016-11-09 16:49                       ` Cyril Hrubis
2016-11-10 10:07                         ` Stanislav Kholmanskikh
2016-11-10 11:39                           ` Cyril Hrubis
2016-11-10 14:15                             ` Stanislav Kholmanskikh
2016-08-31 13:55 ` [LTP] [PATCH] lsmod01: parse a copy of /proc/modules Cyril Hrubis
2016-09-02 14:12   ` Stanislav Kholmanskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8140813.24444.1472477694219.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox