public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Yang Xu (Fujitsu)" <xuyang2018.jy@fujitsu.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v4 4/4] lapi/stat.h: Remove deprecated STATX_ALL macro
Date: Thu, 27 Apr 2023 01:52:27 +0000	[thread overview]
Message-ID: <81df268c-7255-c251-e174-b54fc65037fb@fujitsu.com> (raw)
In-Reply-To: <20230426215655.GC58528@sol.localdomain>



on 2023/04/27 5:56, Eric Biggers wrote:
> On Thu, Apr 06, 2023 at 01:40:22PM +0800, Yang Xu wrote:
>> diff --git a/testcases/kernel/syscalls/statx/statx07.c b/testcases/kernel/syscalls/statx/statx07.c
>> index b13c11f72..c798c7a10 100644
>> --- a/testcases/kernel/syscalls/statx/statx07.c
>> +++ b/testcases/kernel/syscalls/statx/statx07.c
>> @@ -62,15 +62,15 @@ static int get_mode(char *file_name, int flag_type, char *flag_name)
>>   {
>>   	struct statx buf;
>>   
>> -	TEST(statx(AT_FDCWD, file_name, flag_type, STATX_ALL, &buf));
>> +	TEST(statx(AT_FDCWD, file_name, flag_type, STATX_BASIC_STATS | STATX_BTIME, &buf));
>>   
>>   	if (TST_RET == -1) {
>>   		tst_brk(TFAIL | TST_ERR,
>> -			"statx(AT_FDCWD, %s, %s, STATX_ALL, &buf)",
>> +			"statx(AT_FDCWD, %s, %s, STATX_BASIC_STATS | STATX_BTIME, &buf)",
>>   			file_name, flag_name);
>>   	}
>>   
>> -	tst_res(TINFO, "statx(AT_FDCWD, %s, %s, STATX_ALL, &buf) = %o",
>> +	tst_res(TINFO, "statx(AT_FDCWD, %s, %s, STATX_BASIC_STATS | STATX_BTIME, &buf) = %o",
>>   		file_name, flag_name, buf.stx_mode);
>>   
>>   	return buf.stx_mode;
> 
> Looks like this place just wants STATX_BASIC_STATS.

Yes, I will only use STATX_BASIC_STATS for statx07.c

Best Regards
Yang Xu
> 
> - Eric

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-04-27  1:52 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  8:22 [LTP] [PATCH 1/3] lapi/stat.h: Add STATX_DIOALIGN related definition Yang Xu
2023-03-30  8:22 ` [LTP] [PATCH 2/3] syscalls/statx10: Add basic test for STATX_DIOALIGN Yang Xu
2023-03-30 16:46   ` Eric Biggers
2023-03-31 12:56     ` xuyang2018.jy
2023-03-31 19:29       ` Eric Biggers
2023-04-03  1:24         ` xuyang2018.jy
2023-04-03  3:06           ` Eric Biggers
2023-04-03 10:44           ` [LTP] [PATCH v2 1/4] lapi/stat.h: Add STATX_DIOALIGN related definition Yang Xu
2023-04-03 10:44             ` [LTP] [PATCH v2 2/4] syscalls/statx10: Add basic test for STATX_DIOALIGN on regular file Yang Xu
2023-04-03 17:01               ` Eric Biggers
2023-04-04  3:10                 ` xuyang2018.jy
2023-04-04  5:46                   ` xuyang2018.jy
2023-04-03 10:44             ` [LTP] [PATCH v2 3/4] syscalls/statx11: Add basic test for STATX_DIOALIGN on blockdev Yang Xu
2023-04-03 17:04               ` Eric Biggers
2023-04-04  3:14                 ` xuyang2018.jy
2023-04-04  7:30                 ` [LTP] [PATCH v3 1/4] lapi/stat.h: Add STATX_DIOALIGN related definition Yang Xu
2023-04-04  7:30                   ` [LTP] [PATCH v3 2/4] syscalls/statx10: Add basic test for STATX_DIOALIGN on regular file Yang Xu
2023-04-04 21:52                     ` Eric Biggers
2023-04-06  4:52                       ` xuyang2018.jy
2023-04-04  7:30                   ` [LTP] [PATCH v3 3/4] syscalls/statx11: Add basic test for STATX_DIOALIGN on block device Yang Xu
2023-04-04 21:59                     ` Eric Biggers
2023-04-06  4:57                       ` xuyang2018.jy
2023-04-06  5:36                         ` xuyang2018.jy
2023-04-06  5:40                       ` [LTP] [PATCH v4 1/4] lapi/stat.h: Add STATX_DIOALIGN related definition Yang Xu
2023-04-06  5:40                         ` [LTP] [PATCH v4 2/4] syscalls/statx10: Add basic test for STATX_DIOALIGN on regular file Yang Xu
2023-04-26 22:06                           ` Eric Biggers
2023-04-27  3:03                             ` Yang Xu (Fujitsu)
2023-05-01 17:44                               ` Eric Biggers
2023-05-01 17:47                                 ` Eric Biggers
2023-05-08  8:25                                 ` Yang Xu (Fujitsu)
2023-05-08  8:30                                   ` Yang Xu (Fujitsu)
2023-04-06  5:40                         ` [LTP] [PATCH v4 3/4] syscalls/statx11: Add basic test for STATX_DIOALIGN on block device Yang Xu
2023-04-26 22:12                           ` Eric Biggers
2023-04-27  3:37                             ` Yang Xu (Fujitsu)
2023-04-27  3:50                               ` Yang Xu (Fujitsu)
2023-05-01 17:49                                 ` Eric Biggers
2023-05-08  8:26                                   ` Yang Xu (Fujitsu)
2023-04-06  5:40                         ` [LTP] [PATCH v4 4/4] lapi/stat.h: Remove deprecated STATX_ALL macro Yang Xu
2023-04-26 21:56                           ` Eric Biggers
2023-04-27  1:52                             ` Yang Xu (Fujitsu) [this message]
2023-04-26  9:57                         ` [LTP] [PATCH v4 1/4] lapi/stat.h: Add STATX_DIOALIGN related definition Yang Xu (Fujitsu)
2023-04-26 21:56                         ` Eric Biggers
2023-04-27  1:36                           ` Yang Xu (Fujitsu)
2023-04-04  7:30                   ` [LTP] [PATCH v3 4/4] lapi/stat.h: Remove deprecated STATX_ALL macro Yang Xu
2023-04-03 10:44             ` [LTP] [PATCH v2 " Yang Xu
2023-03-30  8:22 ` [LTP] [PATCH 3/3] " Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81df268c-7255-c251-e174-b54fc65037fb@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ebiggers@kernel.org \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox