From: Mark Salyzyn <salyzyn@android.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 2/2] syscalls/select04: Test four syscall variants
Date: Wed, 6 Mar 2019 08:42:55 -0800 [thread overview]
Message-ID: <824b83ab-29ec-ebea-6b79-3b84fea504bb@android.com> (raw)
In-Reply-To: <20190306152430.25219-2-chrubis@suse.cz>
_THANKS_ for the set of changes!
On 03/06/2019 07:24 AM, Cyril Hrubis wrote:
> + case 2: {
> + struct compat_sel_arg_struct arg = {
> + ._n = (long)nfds,
> + ._inp = (long)readfds,
> + ._outp = (long)writefds,
> + ._exp = (long)exceptfds,
> + ._tvp = (long)timeout,
> + };
> +
> + return tst_syscall(__NR_select, &arg);
> + }
This fragment is correct for 32-bit configurations and 64-bit compat,
but for 64-bit binaries it is:
#if defined(__LP64__)
return tst_syscall(__NR_select, nfds, readfds, writefds, exceptfds, timeout);
#else
. . .
#endif
-- Mark
next prev parent reply other threads:[~2019-03-06 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 15:24 [LTP] [RFC PATCH 1/2] tst_test: Add test multiplex function Cyril Hrubis
2019-03-06 15:24 ` [LTP] [RFC PATCH 2/2] syscalls/select04: Test four syscall variants Cyril Hrubis
2019-03-06 16:42 ` Mark Salyzyn [this message]
2019-03-06 16:53 ` [LTP] [RFC PATCH 1/2] tst_test: Add test multiplex function Jan Stancek
2019-03-06 17:00 ` Cyril Hrubis
2019-03-06 17:35 ` Jan Stancek
2019-03-06 18:28 ` Cyril Hrubis
2019-03-06 19:20 ` Jan Stancek
2019-03-07 12:29 ` Cyril Hrubis
2019-03-06 20:58 ` Steve Muckle
-- strict thread matches above, loose matches on Subject: below --
2019-03-06 15:21 Cyril Hrubis
2019-03-06 15:21 ` [LTP] [RFC PATCH 2/2] syscalls/select04: Test four syscall variants Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824b83ab-29ec-ebea-6b79-3b84fea504bb@android.com \
--to=salyzyn@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox