From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] Include lapi/posix_clocks.h in tst_safe_clocks.h
Date: Tue, 26 Feb 2019 10:27:49 -0500 (EST) [thread overview]
Message-ID: <829978276.2945178.1551194869315.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190225234359.8165-1-pvorel@suse.cz>
----- Original Message -----
> Although this not needed, users of tst_safe_clocks.h usually need also
> posix clock flags and it's safer to load them automatically so fixes
> like 938a1023d are not needed any more.
>
> + minor copyright formatting cleanup.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Both look good to me, ack.
Regards,
Jan
> ---
> include/tst_safe_clocks.h | 8 +++++---
> testcases/kernel/syscalls/clock_gettime/clock_gettime01.c | 1 -
> testcases/kernel/syscalls/clock_gettime/clock_gettime02.c | 1 -
> testcases/kernel/syscalls/clock_settime/clock_settime02.c | 1 -
> testcases/kernel/syscalls/statx/statx06.c | 1 -
> 5 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/include/tst_safe_clocks.h b/include/tst_safe_clocks.h
> index 553f8464a..d5cd83394 100644
> --- a/include/tst_safe_clocks.h
> +++ b/include/tst_safe_clocks.h
> @@ -1,11 +1,13 @@
> -// SPDX-License-Identifier: GPL-2.0 or later
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * Copyright (c) Zilogic Systems Pvt. Ltd., 2018
> - * Email : code@zilogic.com
> + * Copyright (c) 2019, Linux Test Project
> + * Copyright (c) Zilogic Systems Pvt. Ltd., 2018
> + * Email : code@zilogic.com
> */
>
> #include <time.h>
> #include "tst_test.h"
> +#include "lapi/posix_clocks.h"
>
> static inline void safe_clock_getres(const char *file, const int lineno,
> clockid_t clk_id, struct timespec *res)
> diff --git a/testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
> b/testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
> index f8028f0f6..d365823b2 100644
> --- a/testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
> +++ b/testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
> @@ -18,7 +18,6 @@
>
> #include "config.h"
> #include "tst_timer.h"
> -#include "lapi/posix_clocks.h"
> #include "tst_safe_clocks.h"
> #include "tst_test.h"
> #include "lapi/syscalls.h"
> diff --git a/testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
> b/testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
> index c08f0f0de..2a29a71e6 100644
> --- a/testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
> +++ b/testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
> @@ -21,7 +21,6 @@
> #include "config.h"
> #include "tst_test.h"
> #include "lapi/syscalls.h"
> -#include "lapi/posix_clocks.h"
> #include "tst_timer.h"
> #include "tst_safe_clocks.h"
>
> diff --git a/testcases/kernel/syscalls/clock_settime/clock_settime02.c
> b/testcases/kernel/syscalls/clock_settime/clock_settime02.c
> index a6df4940a..8db417b6b 100644
> --- a/testcases/kernel/syscalls/clock_settime/clock_settime02.c
> +++ b/testcases/kernel/syscalls/clock_settime/clock_settime02.c
> @@ -11,7 +11,6 @@
> #include "config.h"
> #include "tst_test.h"
> #include "lapi/syscalls.h"
> -#include "lapi/posix_clocks.h"
> #include "tst_timer.h"
> #include "tst_safe_clocks.h"
>
> diff --git a/testcases/kernel/syscalls/statx/statx06.c
> b/testcases/kernel/syscalls/statx/statx06.c
> index 524022499..831f73092 100644
> --- a/testcases/kernel/syscalls/statx/statx06.c
> +++ b/testcases/kernel/syscalls/statx/statx06.c
> @@ -45,7 +45,6 @@
> #include "lapi/stat.h"
> #include "lapi/mount.h"
> #include "lapi/fcntl.h"
> -#include "lapi/posix_clocks.h"
>
> #define MOUNT_POINT "mount_ext"
> #define TEST_FILE MOUNT_POINT"/test_file.txt"
> --
> 2.20.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
next prev parent reply other threads:[~2019-02-26 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 23:43 [LTP] [PATCH 1/2] Include lapi/posix_clocks.h in tst_safe_clocks.h Petr Vorel
2019-02-25 23:43 ` [LTP] [PATCH 2/2] lapi/posix_clocks.h: Include <time.h> before definitions Petr Vorel
2019-02-26 15:27 ` Jan Stancek [this message]
2019-02-26 17:57 ` [LTP] [PATCH 1/2] Include lapi/posix_clocks.h in tst_safe_clocks.h Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829978276.2945178.1551194869315.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox