Linux Test Project
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>, linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] ima_selinux.sh: test2 assumes CONFIG_IMA_DISABLE_HTABLE is configured
Date: Tue, 25 Aug 2026 20:24:57 -0400	[thread overview]
Message-ID: <8564c18ee78ca4f308dc0b7f48ac2f63b295ee00.camel@linux.ibm.com> (raw)
In-Reply-To: <20260825044433.GB22725@pevik>

Hi Petr.

On Tue, 2026-08-25 at 06:44 +0200, Petr Vorel wrote:
[...]
> > On August 21, 2026, Mimi Zohar wrote:
> > > ima_selinux.sh: test2 assumes CONFIG_IMA_DISABLE_HTABLE is configured
> 
> > > +		if ! tst_check_kconfigs "CONFIG_IMA_DISABLE_HTABLE=y"; then
> > > +			tst_res TPASS "Duplicate \"selinux-state\" record missing (CONFIG_IMA_DISABLE_HTABLE not set)"
> 
> I would suggest the same, it makes sense to use TCONF to make it visible that
> it's not an error but OTOH it was not actually tested due
> CONFIG_IMA_DISABLE_HTABLE not set. If you don't mind, I'd change TPASS to TCONF
> before merge (or feel free to send v2 with this change yourself with my
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ).
> 
> Thanks for the fix!

Agreed, it should be TCONF.  Please make the change.

thanks,

Mimi

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-26  0:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 20:06 [LTP] [PATCH] ima_selinux.sh: test2 assumes CONFIG_IMA_DISABLE_HTABLE is configured Mimi Zohar
2026-08-21 20:26 ` [LTP] " linuxtestproject.agent
2026-08-25  4:44   ` Petr Vorel
2026-08-26  0:24     ` Mimi Zohar [this message]
2026-08-26  6:16       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8564c18ee78ca4f308dc0b7f48ac2f63b295ee00.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox