From: Richard Palethorpe <rpalethorpe@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v7 1/1] mmapstress01: refactor to tst_test framework
Date: Mon, 14 Nov 2022 10:00:35 +0000 [thread overview]
Message-ID: <871qq5voer.fsf@suse.de> (raw)
In-Reply-To: <Y26BWsQM33+85Po2@pevik>
Hello,
Petr Vorel <pvorel@suse.cz> writes:
> Hi all,
>
>> Thanks for your work! FYI 2 tiny problems sneaked in, see below.
>
>> runtest/mm contained -t 0.20 option, which caused failure. Fixed in:
>> https://github.com/linux-test-project/ltp/commit/36321277a294c0467219f650fd76aa1a8d310c1d
>
> @Richie This would be even more important to check automatically. If you're able
> to in sparse list test parameters and whether they expect value or are standalone,
> adding process to grep in runtest files should not be hard. WDYT?
Again this is producing meta data with Sparse. I guess it would also be
AST level (i.e. not linearized IR byte code) which Sparse is not that
great at.
Probably this would not be hard to do with a reasonable SA framework.
It is a good idea though, I'm just grumpy about the implementation.
>
> Kind regards,
> Petr
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-14 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 21:58 [LTP] [PATCH v7 0/1] mmapstress01: refactor to ltp framework Edward Liaw via ltp
2022-10-27 21:58 ` [LTP] [PATCH v7 1/1] mmapstress01: refactor to tst_test framework Edward Liaw via ltp
2022-11-08 10:49 ` Richard Palethorpe
2022-11-08 11:19 ` Richard Palethorpe
2022-11-11 16:53 ` Petr Vorel
2022-11-11 17:07 ` Petr Vorel
2022-11-14 10:00 ` Richard Palethorpe [this message]
2022-11-14 9:44 ` Richard Palethorpe
2022-11-14 10:50 ` Cyril Hrubis
2022-11-14 14:17 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qq5voer.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox