* Re: [LTP] [PATCH] Increase judgment on buf. [not found] ` <0cb83efa85ae32d956f81e6b9d4966c38fd54bcb.camel@xry111.site> @ 2023-05-21 8:19 ` Paul Eggert 2023-05-21 8:27 ` Andreas Schwab 0 siblings, 1 reply; 4+ messages in thread From: Paul Eggert @ 2023-05-21 8:19 UTC (permalink / raw) To: Xi Ruoyao, lixing, Carlos O'Donell, Adhemerval Zanella Netto, Peng Fan Cc: libc-alpha@sourceware.org, ltp On 2023-05-20 03:19, Xi Ruoyao via Libc-alpha wrote: > If a LTP test relies on a EFAULT here, then LTP has a bug. You should > tell LTP to fix it then. LTP fstat03 allows either EFAULT or SIGSEGV, but no other behavior, when 'stat' is passed a null pointer. Therefore that test is too strict for POSIX, as the POSIX behavior is undefined. It's also too strict for GNU/Linux, because it insists on SIGSEGV whereas any terminating signal will do (e.g., SIGABRT). Proposed LTP patch attached. -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] Increase judgment on buf. 2023-05-21 8:19 ` [LTP] [PATCH] Increase judgment on buf Paul Eggert @ 2023-05-21 8:27 ` Andreas Schwab 2023-05-21 8:44 ` Paul Eggert 0 siblings, 1 reply; 4+ messages in thread From: Andreas Schwab @ 2023-05-21 8:27 UTC (permalink / raw) To: Paul Eggert Cc: libc-alpha@sourceware.org, Peng Fan, Carlos O'Donell, Xi Ruoyao, Adhemerval Zanella Netto, lixing, ltp On Mai 21 2023, Paul Eggert wrote: > + if (tcases[tc_num].exp_err == EFAULT && WIFSIGNALED(status)) { Can this condition ever be true? -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] Increase judgment on buf. 2023-05-21 8:27 ` Andreas Schwab @ 2023-05-21 8:44 ` Paul Eggert 2023-05-21 9:05 ` Andreas Schwab 0 siblings, 1 reply; 4+ messages in thread From: Paul Eggert @ 2023-05-21 8:44 UTC (permalink / raw) To: Andreas Schwab Cc: libc-alpha@sourceware.org, Peng Fan, Carlos O'Donell, Xi Ruoyao, Adhemerval Zanella Netto, lixing, ltp On 2023-05-21 01:27, Andreas Schwab wrote: >> + if (tcases[tc_num].exp_err == EFAULT && WIFSIGNALED(status)) { > Can this condition ever be true? I don't see why not, if fstat(fd_ok, 0) does a SIGABRT or similar. But perhaps we're interpreting "Can" differently. -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] Increase judgment on buf. 2023-05-21 8:44 ` Paul Eggert @ 2023-05-21 9:05 ` Andreas Schwab 0 siblings, 0 replies; 4+ messages in thread From: Andreas Schwab @ 2023-05-21 9:05 UTC (permalink / raw) To: Paul Eggert Cc: libc-alpha@sourceware.org, Peng Fan, Carlos O'Donell, Xi Ruoyao, Adhemerval Zanella Netto, lixing, ltp I have misinterpreted the first part of the condition. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-22 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <lxnjka-9sevacf455zj-1fthj246gvr4-712jsi8w59t4969pqyxmxkaq-l3n4z6dp0ybpuvpiuudtnfot-dl7onwkii2tq8gtprte6cu4fgip6f-ikuh33-a5p9ixcl44cx2h7mimcgl3xt-13bjom.1684553069255@email.android.com>
[not found] ` <0cb83efa85ae32d956f81e6b9d4966c38fd54bcb.camel@xry111.site>
2023-05-21 8:19 ` [LTP] [PATCH] Increase judgment on buf Paul Eggert
2023-05-21 8:27 ` Andreas Schwab
2023-05-21 8:44 ` Paul Eggert
2023-05-21 9:05 ` Andreas Schwab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox