From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46265C433EF for ; Wed, 13 Jul 2022 05:22:09 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id C7CDC3CA35F for ; Wed, 13 Jul 2022 07:22:06 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E0E443CA178 for ; Wed, 13 Jul 2022 07:21:49 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 2562910005C4 for ; Wed, 13 Jul 2022 07:21:48 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 579EC20116; Wed, 13 Jul 2022 05:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657689708; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kOQ1OCQVGLw9OLdp8wM26XzwWSkqpI2eIjyO97krvNE=; b=mhhJoGnaiGU1g2JcE2hS1+RNAeOhvZYet3t/JxHGXAoIiI1EwIPM+KwInVmRVL22aD5MvI vJuZCb5DKxx06/8lVEnkkRXanh49xOK5QGPCaoi+raquBKyM6sYVu8OEDwnnn81yFdRDAx DhhdjZHEAhy7ynfNtiGZOOtWv+okUmk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657689708; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kOQ1OCQVGLw9OLdp8wM26XzwWSkqpI2eIjyO97krvNE=; b=8f/qsFRa0kN5sBIntEExNQVfctJslMNtJLyiXeBi7RmGIf2sTXSxYaLmUxNQFQ0QdFX36q jjkat4dhismon5Ag== Received: from g78 (unknown [10.163.24.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2393D2C141; Wed, 13 Jul 2022 05:21:48 +0000 (UTC) References: <87k08joqp7.fsf@suse.de> <1657598596-2296-1-git-send-email-xuyang2018.jy@fujitsu.com> User-agent: mu4e 1.6.10; emacs 28.1 From: Richard Palethorpe To: Yang Xu Date: Wed, 13 Jul 2022 06:19:07 +0100 In-reply-to: <1657598596-2296-1-git-send-email-xuyang2018.jy@fujitsu.com> Message-ID: <8735f5oae1.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] security/dirtypipe: Add test for CVE-2022-0847 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, Yang Xu writes: > +static void run(void) > +{ > + off_t offset; > + int data_size, len; > + ssize_t nbytes; > + > + offset = 1; Still setting offset to 1. > + data_size = strlen(TEXT); > + > + fd = SAFE_OPEN(TESTFILE, O_RDONLY); > + > + prepare_pipe(); > + > + offset = 0; > + /* > + * splice one byte from the start into the pipe; > + * this will add a reference to the page cache, but since > + * copy_page_to_iter_pipe() does not initialize the "flags", > + * PIPE_BUF_FLAG_CAN_MERGE is still set > + */ > + nbytes = splice(fd, &offset, p[1], NULL, 1, 0); As offset is 0 we can just pass NULL. Otherwise all looks good, I'll fix it up and merge it. -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp