Re: [LTP] [PATCH v3] save_restore: Introduce new struct field for flags

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> > Would you consider adding TST_SR_TCONF_MISSING and TST_SR_TCONF_RO?
>> 
>> I could set both to 0, if that's OK.
>
> I suppose that would work fine.
>
>> >> +* 'TST_SR_FAIL_MISSING' – End test with 'TBROK' if the file does not exist
>> > 
>> > This FAIL part in this name is quite misleading since the test ends with
>> > TBROK. I would say that it would be much more clear if it was named
>> > TST_SR_TBROK_MISSING.
>> 
>> Then I should also rename TST_SR_REQUIRED to TST_SR_TBROK, rename 
>> TST_SR_COND_ACCESS to TST_SR_SKIP and add TST_SR_TCONF for the two new 
>> flags.
>
> That sounds good to me, it's much closely mapped to the actual test
> result types and should be clear enough.

Uh, OK, please ignore my comment on the same subject.

>
> -- 
> Cyril Hrubis
> chrubis@suse.cz


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp