From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C678ECAAD5 for ; Fri, 2 Sep 2022 10:03:47 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 452923CA8C7 for ; Fri, 2 Sep 2022 12:03:45 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 5FC893CA644 for ; Fri, 2 Sep 2022 12:03:36 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 700161000F34 for ; Fri, 2 Sep 2022 12:03:34 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 6BE1A34332 for ; Fri, 2 Sep 2022 10:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662113014; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=woXEnY5McNuSiOt6HV1H8leRWxdzBuHUsxtCPX9Z3k4=; b=1na1DiNAZWhgwaTTHiFMY4IVdoQIgIY9QfXaze9GuY4Afi94srYJbqGmzVwEtzrTwJQN2I 490lDWFWVtsM6pAzyyXzMfoxDwsH2mfltV+qC5aKXrTi9skmE8VaNqJpJhMlOBofXdHcN7 ZuYJsxaQnGStBBR8WsiFJCobRGCC75M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662113014; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=woXEnY5McNuSiOt6HV1H8leRWxdzBuHUsxtCPX9Z3k4=; b=5X3SigAzy+iKpn83mOEJg1/XFY1jovtbIUn8bSGriIdoh44xe1aGeNRDZKrRWJ1BnpUb3D M6Nof7Ib2s0jOuBg== Received: from g78 (unknown [10.163.24.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EB0362C141; Fri, 2 Sep 2022 10:03:28 +0000 (UTC) References: <20220727151657.2242-1-pvorel@suse.cz> User-agent: mu4e 1.6.10; emacs 28.1 From: Richard Palethorpe To: Petr Vorel Date: Fri, 02 Sep 2022 10:57:17 +0100 In-reply-to: <20220727151657.2242-1-pvorel@suse.cz> Message-ID: <874jxq14ay.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] lib: Add ROD shell API test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, Petr Vorel writes: > Signed-off-by: Petr Vorel > --- > lib/newlib_tests/runtest.sh | 2 +- > lib/newlib_tests/shell/rod.sh | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 1 deletion(-) > create mode 100755 lib/newlib_tests/shell/rod.sh > > diff --git a/lib/newlib_tests/runtest.sh b/lib/newlib_tests/runtest.sh > index f136bcb88..5b75fe2c7 100755 > --- a/lib/newlib_tests/runtest.sh > +++ b/lib/newlib_tests/runtest.sh > @@ -8,7 +8,7 @@ tst_fuzzy_sync03 test_zero_hugepage.sh test_kconfig.sh > test_children_cleanup.sh}" > > LTP_SHELL_API_TESTS="${LTP_SHELL_API_TESTS:-shell/tst_check_driver.sh > -shell/tst_check_kconfig0[1-5].sh shell/net/*.sh}" > +shell/tst_check_kconfig0[1-5].sh shell/rod.sh shell/net/*.sh}" > > cd $(dirname $0) > PATH="$PWD/../../testcases/lib/:$PATH" > diff --git a/lib/newlib_tests/shell/rod.sh b/lib/newlib_tests/shell/rod.sh > new file mode 100755 > index 000000000..e05516d0b > --- /dev/null > +++ b/lib/newlib_tests/shell/rod.sh > @@ -0,0 +1,30 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0-or-later > +# Copyright (c) 2022 Petr Vorel > + > +TST_TESTFUNC="test" > +TST_NEEDS_TMPDIR=1 > +TST_CNT=3 > + > +test1() > +{ > + ROD cd / > + EXPECT_PASS [ "$PWD" != "/" ] > +} > + > +test2() > +{ > + ROD echo foo > /nonexisting-file If we are running as root then this will succeed? I suppose we don't usually run the lib tests as root, but wouldn't it be better to create a file and write protect it, then try redirecting to it? > + tst_res TPASS "ROD redirecting without qoting continue on failure. NOTE: proper syntax needs to escape '>': ROD echo foo \> /nonexisting-file" > + EXPECT_FAIL 'cat /nonexisting-file' > +} > + > +test3() > +{ > + ROD echo foo \> file > + tst_res TPASS "ROD redirect quoting syntax works" > + EXPECT_PASS '[ $(cat file) = foo ]' > +} > + > +. tst_test.sh > +tst_run > -- > 2.37.1 -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp