From: Richard Palethorpe <rpalethorpe@suse.de>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 3/3] memcontrol04: Copy from kselftest
Date: Thu, 10 Feb 2022 07:34:25 +0000 [thread overview]
Message-ID: <875ypnkr8v.fsf@suse.de> (raw)
In-Reply-To: <CAEemH2cb65kihwnkMMKSr8FRXJ_SY3jPnSxPPp-Kk_xBrJAeZw@mail.gmail.com>
Hello Li,
Li Wang <liwang@redhat.com> writes:
> This test has a high repetition with memcontrol03, I'm just
> wondering if any possibility to merge together by defining a
> struct tcase?
>
> static struct tcase {
> char *ctrl_file;
> } tcases[] = {
> {"memory.min"},
> {"memory.low"}
> };
There are a number of places where the logic is different. We would end
up a with a test full of branches. There is some boilerplate which is
the same for now, but that could also diverge between tests.
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-10 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 14:03 [LTP] [PATCH 0/3] memcontrol04 and s/cgroup/cg/ Richard Palethorpe via ltp
2022-02-08 14:03 ` [LTP] [PATCH 1/3] API/cgroup: Add memory.{events, low} Richard Palethorpe via ltp
2022-02-16 15:27 ` Cyril Hrubis
2022-02-17 3:14 ` Li Wang
2022-02-08 14:03 ` [LTP] [PATCH 2/3] API/cgroup: Shorten cgroup to cg in most symbols Richard Palethorpe via ltp
2022-02-09 4:51 ` Li Wang
2022-02-10 7:32 ` Richard Palethorpe
2022-02-16 15:26 ` Cyril Hrubis
2022-02-17 3:13 ` Li Wang
2022-02-17 5:37 ` Richard Palethorpe
2022-02-08 14:03 ` [LTP] [PATCH 3/3] memcontrol04: Copy from kselftest Richard Palethorpe via ltp
2022-02-09 10:47 ` Li Wang
2022-02-10 7:34 ` Richard Palethorpe [this message]
2022-02-09 11:05 ` Li Wang
2022-02-10 6:23 ` Li Wang
2022-02-10 7:12 ` Li Wang
2022-02-14 5:40 ` Richard Palethorpe
2022-02-16 10:13 ` Li Wang
2022-02-17 4:35 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ypnkr8v.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox