Re: [LTP] [PATCH 2/2] check: Add LTP-005 null termination check on test.tags

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> This does not explicitly check for zero at the end of an array. For
>> one thing the zero is implicit when one writes '{}'. We just get an
>> empty expression list. When one writes '{NULL, 0}', we get an implicit
>
> I would vote for dropping the part that checks for implicit cats so that
> we unify all code on {} for sentinels. I guess that all we would have to
> do is to drop the loop and only check if the list is empty.

Yes, indeed, it probably simplifies things a lot more than is
immediately obvious as well. I will reroll.

>
> Other than that the code looks good to me:
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp