From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83204C433F5 for ; Fri, 5 Nov 2021 11:01:52 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 899566124F for ; Fri, 5 Nov 2021 11:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 899566124F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B6E1F3C756B for ; Fri, 5 Nov 2021 12:01:49 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 49BE13C4B8F for ; Fri, 5 Nov 2021 12:01:40 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 3FCC6600702 for ; Fri, 5 Nov 2021 12:01:38 +0100 (CET) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 91F1F21892; Fri, 5 Nov 2021 11:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1636110098; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kdnAhgC5ru5wVJV/+QXGuKT6ULgmdiQJAWyPE79WNpE=; b=BHMy8ihasX5zX92bnHJfOIOEx4Zhc5SpLzn8ANEg8ovOldVDNH03QVAAjuG19Zp7bRs0dx zzHevXOzyxIWVNNtQRnv11H7qDyac+yTgecnGeOS5utsy9ktNqSpRB1hSeKTCM8r6kEuXB sFpPJgs6DMk2wLRp7n+O7oUD11Sh0cc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1636110098; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kdnAhgC5ru5wVJV/+QXGuKT6ULgmdiQJAWyPE79WNpE=; b=eA6Lx0QXXPjnDnZSO4foV67L79MFufDBXrCl87TbnT2dwc83TQXyULxFQYqxHkgEC0g0P6 rje0iQpK/9vH4fBA== Received: from g78 (unknown [10.163.24.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D46A32C144; Fri, 5 Nov 2021 11:01:37 +0000 (UTC) References: <20210224165045.17738-1-chrubis@suse.cz> <20210224165045.17738-3-chrubis@suse.cz> User-agent: mu4e 1.6.5; emacs 27.2 From: Richard Palethorpe To: Petr Vorel Date: Fri, 05 Nov 2021 10:56:47 +0000 In-reply-to: Message-ID: <875yt6988e.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [Automated-testing] [PATCH v2 2/5] lib: Add minimalistic json parser X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: Carlos Hernandez , Michal Simek , automated-testing@yoctoproject.org, Orson Zhai , ltp@lists.linux.it, automated-testing@lists.yoctoproject.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, "Petr Vorel" writes: > Hi Cyril, > > Reviewed-by: Petr Vorel > > Nice work! > >> +static int eatws(struct tst_json_buf *buf) >> +{ >> + while (!buf_empty(buf)) { >> + switch (buf->json[buf->off]) { >> + case ' ': >> + case '\t': >> + case '\n': >> + case '\f': > Shouldn't there be '\r' as well? (handled at copy_str()). Yeah, it seems to be in the spec. At any rate, I wouldn't mind this patch being applied immediately because there is more than one WIP it may be useful for. Reviewed-by: Richard Palethorpe >> + break; >> + default: >> + goto ret; >> + } >> + >> + buf->off += 1; >> + } >> +ret: >> + return buf_empty(buf); >> +} > > > Kind regards, > Petr > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#872): https://lists.yoctoproject.org/g/automated-testing/message/872 > Mute This Topic: https://lists.yoctoproject.org/mt/80881162/3616767 > Group Owner: automated-testing+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/automated-testing/unsub [rpalethorpe@suse.de] > -=-=-=-=-=-=-=-=-=-=-=- -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp