public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Ian Wienand <iwienand@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] kernel/device-drivers/zram/zram01.sh : don't fill from /dev/zero
Date: Thu, 21 Sep 2023 10:34:16 +0100	[thread overview]
Message-ID: <877cojg95o.fsf@suse.de> (raw)
In-Reply-To: <ZQuZrkayZ+04bC2f@fedora19.localdomain>

Hello,

Ian Wienand <iwienand@redhat.com> writes:

> On Mon, Sep 18, 2023 at 09:24:47AM +0100, Richard Palethorpe wrote:
>> I did miss that, however it's actually more rigorous (read "complete")
>> to test these things seperately. Or even better to test them seperately
>> then together. Because if only writing out same-page's and a single page
>> with some meta-data in results in a bug, then your method would not find
>> that.
>
> I've just posted v3 [1] that separates out the two testing paths which
> I hope addresses these concerns.

Great! please note that in the mean time I merged Petr's patch. So you
may need to rebase. I haven't looked at it yet due to the upcoming
release.

>
> Thanks
>
> -i
>
> [1] https://lore.kernel.org/ltp/ZQuYiFMOSq1tMTBs@fedora19.localdomain/T/#u


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-09-21  9:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  1:51 [LTP] [PATCH] kernel/device-drivers/zram/zram01.sh : add a sync Ian Wienand
2023-08-03 10:52 ` Cyril Hrubis
2023-08-03 10:59   ` Martin Doucha
2023-08-03 11:02     ` Cyril Hrubis
2023-08-03 12:32     ` Ian Wienand
2023-08-08  3:56 ` [LTP] [PATCH v2] kernel/device-drivers/zram/zram01.sh : don't fill from /dev/zero Ian Wienand
2023-08-30  8:20   ` Richard Palethorpe
2023-09-07  6:46     ` Ian Wienand
2023-09-07  8:26       ` Richard Palethorpe
2023-09-08  1:58         ` Ian Wienand
2023-09-07 10:18       ` Martin Doucha
2023-09-07 22:29         ` Ian Wienand
2023-09-08  9:21           ` Martin Doucha
2023-09-12  1:03             ` Ian Wienand
2023-09-13 14:35               ` Richard Palethorpe
2023-09-13 22:21                 ` Ian Wienand
2023-09-14  7:37                   ` Richard Palethorpe
2023-09-14 11:04                     ` Ian Wienand
2023-09-18  8:24                       ` Richard Palethorpe
2023-09-21  1:17                         ` Ian Wienand
2023-09-21  9:34                           ` Richard Palethorpe [this message]
2023-09-21  1:12   ` [LTP] [PATCH v3] kernel/device-drivers/zram/zram01.sh : fill with compressible data Ian Wienand
2023-11-22 11:24     ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cojg95o.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=iwienand@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox