public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] read_all: scale down how many times we read by default
Date: Tue, 09 Jun 2020 13:45:57 +0100	[thread overview]
Message-ID: <877dwgxv96.fsf@our.domain.is.not.set> (raw)
In-Reply-To: <33c4abf347e2de96f89b9acea02d731e47dbf2a9.1591700131.git.jstancek@redhat.com>

Hello,

Jan Stancek <jstancek@redhat.com> writes:

> read_all is running into timeouts on high cpu systems, where
> access to some per-cpu files is protected by a lock. Latest
> example is /sys/kernel/tracing/per_cpu/*.
>
> At the moment we read each file 10 times, and we have been
> excluding files that take too long. Rather than expanding
> blacklist, scale the default down to 3.
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>  runtest/fs | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/runtest/fs b/runtest/fs
> index 464ba8fb9686..5892e9fdaee5 100644
> --- a/runtest/fs
> +++ b/runtest/fs
> @@ -69,9 +69,9 @@ fs_di fs_di -d $TMPDIR
>  # Was not sure why it should reside in runtest/crashme and won't get tested ever
>  proc01 proc01 -m 128
>  
> -read_all_dev read_all -d /dev -p -q -r 10
> -read_all_proc read_all -d /proc -q -r 10
> -read_all_sys read_all -d /sys -q -r 10
> +read_all_dev read_all -d /dev -p -q -r 3
> +read_all_proc read_all -d /proc -q -r 3
> +read_all_sys read_all -d /sys -q -r 3
>  
>  #Run the File System Race Condition Check tests as well
>  fs_racer fs_racer.sh -t 5
> -- 
> 2.18.1

OK this makes sense. We shouldn't be stress testing the system in this
runtest file.

-- 
Thank you,
Richard.

  parent reply	other threads:[~2020-06-09 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:55 [LTP] [PATCH] read_all: scale down how many times we read by default Jan Stancek
2020-06-09 12:27 ` Li Wang
2020-06-09 12:45 ` Richard Palethorpe [this message]
2020-06-09 13:33   ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dwgxv96.fsf@our.domain.is.not.set \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox