From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D15C433F5 for ; Fri, 24 Sep 2021 10:31:05 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85C3161107 for ; Fri, 24 Sep 2021 10:31:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85C3161107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1E1A63C8F39 for ; Fri, 24 Sep 2021 12:31:04 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1CEC93C848C for ; Fri, 24 Sep 2021 12:30:55 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 4CBF060222B for ; Fri, 24 Sep 2021 12:30:53 +0200 (CEST) Received: from relay1.suse.de (relay1.suse.de [149.44.160.133]) by smtp-out2.suse.de (Postfix) with ESMTP id 80F681FFE6 for ; Fri, 24 Sep 2021 10:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632479453; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZgTkdxYvtxgmJkuqVy8mkZ7Xkxl2a1SZhv5CsWAw1+k=; b=I8CtE94Na0c23bI/RuPrqfjPHcsu2YMa+PualBTWmzW6EldM+rqGwcwPcvTVFXIBmPWAVn EgRqiCN7IoBvMNf7ddL12jA0XUeFAQYw99Z+Kai6zWM6fyCepJWcvQI+/JsINc/7h5vDt3 5/YhNajJvOoq5czaNf1qcZojq9aUoHM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632479453; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZgTkdxYvtxgmJkuqVy8mkZ7Xkxl2a1SZhv5CsWAw1+k=; b=kiGGcyWIdV0W4fmwxbHhG2Yz9d6H3BZOEQVwK6Jg+eXS6um4RaIvfhry6v2so8IP2SzEhf /KYAUrY6kSFo2yAA== Received: from g78 (unknown [10.163.24.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay1.suse.de (Postfix) with ESMTPS id 45D0E25D3E; Fri, 24 Sep 2021 10:30:53 +0000 (UTC) References: <20210924092111.20012-1-rpalethorpe@suse.com> User-agent: mu4e 1.4.15; emacs 27.2 From: Richard Palethorpe To: Petr Vorel In-reply-to: Date: Fri, 24 Sep 2021 11:30:52 +0100 Message-ID: <878rzml0yr.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/2] msgrcv07: Check negative msg type filters X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello Petr, Petr Vorel writes: > Hi Richie, > > ... >> +++ b/testcases/kernel/syscalls/ipc/msgrcv/msgrcv07.c >> @@ -232,6 +232,13 @@ static void test_negative_msgtyp(void) >> "-msgtyp didn't get the first message in the queue with the lowest type"); >> } > >> + TST_EXP_FAIL(msgrcv(queue_id, &rcv_buf, MSGSIZE, -MSGTYPE1, IPC_NOWAIT), >> + ENOMSG, >> + "-msgtype didn't recv next lowest msg"); >> + TST_EXP_FAIL(msgrcv(queue_id, &rcv_buf, MSGSIZE, -MSGTYPE1, MSG_EXCEPT | IPC_NOWAIT), >> + ENOMSG, >> + "-msgtype (with except) didn't recv next lowest msg"); > nit: I'd use msgtyp instead of msgtype (although it looks like typo, it's used > without 'e' as a parametr name in man msgop(2) and also throughout this test > (obviously can be changed during merge). Sure, sounds good. > > Kind regards, > Petr -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp