public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] fs_bind rework
Date: Fri, 25 Jun 2021 12:39:22 +0100	[thread overview]
Message-ID: <878s2y41hx.fsf@suse.de> (raw)
In-Reply-To: <YNRZKs9cHbGxzg4Q@pevik>

Hello all,

>> This would make every single fs_bind test a single ltp test (~100).
>> I do not think that runtime increases significantly, because as far as I see
>> it from first glance, test_fs_bind.sh resets the "sandbox" used for the
>> tests before every test anyway.
> Yep, I wouldn't be worry about increased runtime, this is actually the preferred
> approach. Also, various tests can be probably grouped into single shell test,
> with $TST_CNT (looking into tests in fs_bind/cloneNS).

I guess there is no performance difference in this case. What really
matters is if the tests are all just slight variations on each other. So
having them in one file looks nice and shows exactly what the
differences between tests are.

>
>> If there is no objection, I would give converting the tests a shot.
> +1
>
>> J?rg
>
> Kind regards,
> Petr


-- 
Thank you,
Richard.

      reply	other threads:[~2021-06-25 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  9:29 [LTP] [RFC] fs_bind rework Joerg Vehlow
2021-06-24 10:06 ` Petr Vorel
2021-06-25 11:39   ` Richard Palethorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s2y41hx.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox