Re: [LTP] [PATCH v4] statvfs01: Convert to new LTP API

Richard Palethorpe
2022-12-05T10:46:12Z

Hello,

Avinesh Kumar <akumar@suse.de> writes:

> Removed the TINFO statements,
> Added a validation of statvfs.f_namemax field by trying to create
> files of valid and invalid length names.
>
> Signed-off-by: Avinesh Kumar <akumar@suse.de>
> ---
> testcases/kernel/syscalls/statvfs/statvfs01.c | 102 ++++++------------
> 1 file changed, 33 insertions(+), 69 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/statvfs/statvfs01.c b/testcases/kernel/syscalls/statvfs/statvfs01.c
> index e3b356c93..b59d2e450 100644
> --- a/testcases/kernel/syscalls/statvfs/statvfs01.c
> +++ b/testcases/kernel/syscalls/statvfs/statvfs01.c
> @@ -1,92 +1,56 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (c) Wipro Technologies Ltd, 2005. All Rights Reserved.
> * AUTHOR: Prashant P Yendigeri <prashant.yendigeri@wipro.com>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it would be useful, but
> - * WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> - *
> - * You should have received a copy of the GNU General Public License along
> - * with this program; if not, write the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> - *
> + * Copyright (c) 2022 SUSE LLC Avinesh Kumar <avinesh.kumar@suse.com>
> */
> -/*
> - * DESCRIPTION
> - * This is a Phase I test for the statvfs(2) system call.
> - * It is intended to provide a limited exposure of the system call.
> - * This call behaves similar to statfs.
> +
> +/*\
> + * [Description]
> + *
> + * Verify that statvfs() executes successfully for all
> + * available filesystems. Verify statvfs.f_namemax field
> + * by trying to create files of valid and invalid length names.
> */
>
> #include <stdio.h>
> -#include <unistd.h>
> -#include <errno.h>
> #include <sys/statvfs.h>
> -#include <stdint.h>
> -
> -#include "test.h"
> -
> -#define TEST_PATH "/"
> +#include "tst_test.h"
>
> -static void setup(void);
> -static void cleanup(void);
> +#define MNT_POINT "mntpoint"
> +#define TEST_PATH MNT_POINT"/testfile"
>
> -char *TCID = "statvfs01";
> -int TST_TOTAL = 1;
> -
> -int main(int ac, char **av)
> +static void run(void)
> {
> struct statvfs buf;
> - int lc;
> -
> - tst_parse_opts(ac, av, NULL, NULL);
> -
> - setup();
> -
> - for (lc = 0; TEST_LOOPING(lc); lc++) {
> + char *valid_fname, *toolong_fname;
> + long fs_type;
>
> - tst_count = 0;
> + TST_EXP_PASS(statvfs(TEST_PATH, &buf));
>
> - TEST(statvfs(TEST_PATH, &buf));
> + valid_fname = SAFE_MALLOC(buf.f_namemax - 1);
> + toolong_fname = SAFE_MALLOC(buf.f_namemax + 1);
>
> - if (TEST_RETURN == -1) {
> - tst_resm(TFAIL | TTERRNO, "statvfs(%s, ...) failed",
> - TEST_PATH);
> - } else {
> - tst_resm(TPASS, "statvfs(%s, ...) passed", TEST_PATH);
> - }
> + memset(valid_fname, 'a', buf.f_namemax - 1);
> + memset(toolong_fname, 'b', buf.f_namemax + 1);
>
> - }
> + fs_type = tst_fs_type(TEST_PATH);
> + if (fs_type != TST_VFAT_MAGIC && fs_type != TST_EXFAT_MAGIC)
> + TST_EXP_FD(creat(valid_fname, 0444));

I suppose, thanks to Petr, we now know using a unicode character will
allow you to construct a valid name of the maximum length.

--
Thank you,
Richard.