From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/3] lib: Add personality fallback and SAFE macro
Date: Thu, 10 Aug 2017 09:24:23 +0200 [thread overview]
Message-ID: <87a8376g2g.fsf@our.domain.is.not.set> (raw)
In-Reply-To: <20170809132907.GG32573@rei.lan>
Hello Metan,
Cyril Hrubis writes:
> Hi!
>> +#ifndef PERSONALITY_H
>> +#define PERSONALITY_H
>> +
>> +#include <sys/personality.h>
>> +
>> +#if !(HAVE_DECL_UNAME26 == 1 || defined(UNAME26))
> ^
> Where is this macro from, I cannot see it anywhere.
>
> Have you forgotten git add on configure.ac or something?
Sorry, I am not sure what has happened there.
>
> And I doubt that we need anything else than:
>
> #ifndef UNAME26
> # define UNAME26 0x0020000
> #endif
>
> here...
It is defined as an enum in glibc, but as a macro in musl. I guess it
doesn't matter if macro covers the enum though, except maybe that some
debugging symbol is lost.
--
Thank you,
Richard.
prev parent reply other threads:[~2017-08-10 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 14:47 [LTP] [PATCH v4 1/3] lib: Add personality fallback and SAFE macro Richard Palethorpe
2017-08-08 14:47 ` [LTP] [PATCH v4 2/3] CVE-2012-0957: Use SAFE_PERSONALITY Richard Palethorpe
2017-08-08 14:47 ` [LTP] [PATCH v4 3/3] Test for CVE-2016-10044 mark AIO pseudo-fs noexec Richard Palethorpe
2017-08-09 13:29 ` [LTP] [PATCH v4 1/3] lib: Add personality fallback and SAFE macro Cyril Hrubis
2017-08-10 7:24 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8376g2g.fsf@our.domain.is.not.set \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox