public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] syscalls/statx04: use stx_attributes_mask before test
Date: Mon, 15 Nov 2021 10:21:30 +0000	[thread overview]
Message-ID: <87bl2ld89b.fsf@suse.de> (raw)
In-Reply-To: <YZI0aEoJt5c9bqTz@yuki>

Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> Note that even if you move setting the flags to the top. This will still
>> result in all unset flags becoming TCONF instead of TFAIL.
>> 
>> IMO statx is broken on older kernels except for ext4. It can be fixed by
>> backporting patches. One of the main use cases for LTP is to find
>> missing backports.
>
> That was my point as well.
>
> I guess that the last time I've proposed to create a separate test that
> just tests that these flags are set as expected for a all filesystems
> and that test would have the patches that fixed that as a tags set. That
> would make it clearer what is wrong and what should be backported.
>
> Once we have that test implemented we can change this test as this patch
> does.

Or perhaps we could pass a flag to this test to ignore kernel versions
which are known not to work?

-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2021-11-15 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  8:32 [LTP] [PATCH v4] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2021-11-12 10:21 ` Richard Palethorpe
2021-11-15 10:20   ` Cyril Hrubis
2021-11-15 10:21     ` Richard Palethorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl2ld89b.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox