From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/4] lib: add new cgroup test API
Date: Thu, 24 Sep 2020 09:55:47 +0100 [thread overview]
Message-ID: <87blhvy2ng.fsf@suse.de> (raw)
In-Reply-To: <CAEemH2eCEyebEBZhuQJ+FHs9UpWw_+A=D0vJbx6g8KixPTH4jA@mail.gmail.com>
Hello,
Li Wang <liwang@redhat.com> writes:
>> Perhaps you meant:
>>
>> if (tst_is_mounted("cgroup"))
>> cg_ver = TST_CGROUP_V1;
>> else
>> cg_ver = TST_CGROUP_V2;
>>
>
> This is not enough for the version choice. As tst_is_mounted(?cgroup?) can't
> distinguish precisely what "cgroup" or "cgroup2" has been mounted. Because
> the function is fuzzy matching a string.
>> >
>> > To be honest, I hope a Linux distribution provides a pure way in cgroup
>> > using, which means just mounting V1 or V2 but not to mix together. Or, do
>> > you think LTP should handle the situation for the v1&v2 mixing mount?
>>
>> For now, I think we just need to use V1 if it is mounted. I don't like
>> the fact we have both mounted, but it seems most software can handle it,
>> so LTP should as well.
>>
>
> Agreed.
OK, I will send a patch unless you send one first.
--
Thank you,
Richard.
prev parent reply other threads:[~2020-09-24 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 9:50 [LTP] [PATCH v4 1/4] lib: add new cgroup test API Li Wang
2020-06-09 9:51 ` [LTP] [PATCH v4 2/4] mem: take use of new cgroup API Li Wang
2020-06-09 9:51 ` [LTP] [PATCH v4 3/4] mem: remove the old " Li Wang
2020-06-09 9:51 ` [LTP] [PATCH v4 4/4] mm: add cpuset01 to runtest file Li Wang
2020-06-19 7:35 ` Petr Vorel
2020-06-09 10:42 ` [LTP] [PATCH v4 1/4] lib: add new cgroup test API Jan Stancek
2020-06-10 10:12 ` Li Wang
2020-06-19 3:07 ` Li Wang
2020-06-22 13:10 ` Petr Vorel
2020-06-23 0:10 ` Li Wang
2020-09-23 11:03 ` Richard Palethorpe
2020-09-23 12:23 ` Li Wang
2020-09-23 13:14 ` Richard Palethorpe
2020-09-23 14:40 ` Li Wang
2020-09-24 8:55 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blhvy2ng.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).