Re: [LTP] [PATCH 1/2] syscalls/renameat: Remove renameat fallback definition

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello,

Xiao Yang <yangx.jy@fujitsu.com> writes:

> Hi Xu,
>
> 1) Please explain why you drop the fallback definition by adding a
> commit message.

Yes, I don't want to remove this code unless there is a good argument
why it is safe.

Especially as the code is small and not causing any issues that I am
aware of.

Setting this to changes requested

> 2) I think the related code in the following file can also be removed:
> configure.ac
> include/lapi/syscalls/aarch64.in
> include/lapi/syscalls/arc.in
> include/lapi/syscalls/arm.in
> include/lapi/syscalls/hppa.in
> include/lapi/syscalls/i386.in
> include/lapi/syscalls/ia64.in
> include/lapi/syscalls/loongarch.in
> include/lapi/syscalls/mips_n32.in
> include/lapi/syscalls/mips_n64.in
> include/lapi/syscalls/mips_o32.in
> include/lapi/syscalls/powerpc.in
> include/lapi/syscalls/powerpc64.in
> include/lapi/syscalls/s390.in
> include/lapi/syscalls/s390x.in
> include/lapi/syscalls/sh.in
> include/lapi/syscalls/sparc.in
> include/lapi/syscalls/sparc64.in
> include/lapi/syscalls/x86_64.in
>
> Other than those, it looks good to me.
> Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>
>
> Best Regards,
> Xiao Yang
>
> On 2023/8/24 19:10, Yang Xu wrote:
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>> ---
>>   include/lapi/renameat.h                       | 23 -------------------
>>   .../kernel/syscalls/renameat/renameat01.c     |  1 -
>>   2 files changed, 24 deletions(-)
>>   delete mode 100644 include/lapi/renameat.h
>> diff --git a/include/lapi/renameat.h b/include/lapi/renameat.h
>> deleted file mode 100644
>> index abf4c1d6e..000000000
>> --- a/include/lapi/renameat.h
>> +++ /dev/null
>> @@ -1,23 +0,0 @@
>> -// SPDX-License-Identifier: GPL-2.0-or-later
>> -/*
>> - * Copyright (c) International Business Machines  Corp., 2007
>> - * Copyright (c) 2014 Fujitsu Ltd.
>> - */
>> -
>> -#ifndef LAPI_RENAMEAT_H__
>> -#define LAPI_RENAMEAT_H__
>> -
>> -#include <sys/types.h>
>> -#include "config.h"
>> -#include "lapi/syscalls.h"
>> -
>> -#if !defined(HAVE_RENAMEAT)
>> -static inline int renameat(int olddirfd, const char *oldpath, int newdirfd,
>> -                           const char *newpath)
>> -{
>> -	return tst_syscall(__NR_renameat, olddirfd, oldpath, newdirfd,
>> -					newpath);
>> -}
>> -#endif
>> -
>> -#endif /* LAPI_RENAMEAT_H__ */
>> diff --git a/testcases/kernel/syscalls/renameat/renameat01.c b/testcases/kernel/syscalls/renameat/renameat01.c
>> index 3de103563..c318a7971 100644
>> --- a/testcases/kernel/syscalls/renameat/renameat01.c
>> +++ b/testcases/kernel/syscalls/renameat/renameat01.c
>> @@ -50,7 +50,6 @@
>>   #include "test.h"
>>   #include "safe_macros.h"
>>   #include "lapi/fcntl.h"
>> -#include "lapi/renameat.h"
>>     #define MNTPOINT "mntpoint"
>>   #define TESTDIR "testdir"


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp