From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2892C433F5 for ; Tue, 11 Oct 2022 09:25:50 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9C1143CAE9D for ; Tue, 11 Oct 2022 11:25:48 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 4817D3CAE81 for ; Tue, 11 Oct 2022 11:25:37 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 5BFAE1A0099C for ; Tue, 11 Oct 2022 11:25:35 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9B8B021D4A; Tue, 11 Oct 2022 09:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1665480335; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vBBbJleFXgRx4GHepg85hACsQI2gD7reiat8+PfYWhA=; b=WxMO/aSddyFm786Timk+vBQgl9LKWvdeC3JhEcr+Hs3g2JmxojS/WXtD/wVMJJrj5KvOaC zMU9At7KtxlUzFiR576Czr/Roo36KPYMJkl6GRzdOgfBSWqGFvnxhc2noei9l/klPIO1ER QxmOo/7Jr5d22qqTMlWvY127kjMVCD8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1665480335; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vBBbJleFXgRx4GHepg85hACsQI2gD7reiat8+PfYWhA=; b=yqdktjpUbuinTEUTx2aI3qPsaICNtKVnqUPADIT3fLJEjjYjXeey8F0lSV8BSI25fqbS95 DXnW76r6TzN/4DCg== Received: from g78 (unknown [10.100.228.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 215DA2C141; Tue, 11 Oct 2022 09:25:35 +0000 (UTC) References: <20220722120501.28670-1-andrea.cervesato@suse.com> <20220722120501.28670-3-andrea.cervesato@suse.com> <87r11nw0qv.fsf@suse.de> <945eb0ee-b346-5729-3dda-4bff39bb52d9@suse.com> <87fsha2lge.fsf@suse.de> User-agent: mu4e 1.6.10; emacs 28.1 From: Richard Palethorpe To: rpalethorpe@suse.de Date: Tue, 11 Oct 2022 10:17:52 +0100 In-reply-to: <87fsha2lge.fsf@suse.de> Message-ID: <87czay90fl.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 2/7] Refactor mqns_01 using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, Richard Palethorpe writes: > Hello, > > Andrea Cervesato writes: > >> Hi! >> >> On 8/11/22 11:53, Richard Palethorpe wrote: >>> Hello, >>> >>> Andrea Cervesato via ltp writes: >>> >>>> Signed-off-by: Andrea Cervesato >>>> --- >>>> runtest/containers | 3 +- >>>> testcases/kernel/containers/mqns/common.h | 101 +++++++++++ >>>> testcases/kernel/containers/mqns/mqns_01.c | 193 +++++++-------------- >>>> 3 files changed, 166 insertions(+), 131 deletions(-) >>>> create mode 100644 testcases/kernel/containers/mqns/common.h >>>> >>>> diff --git a/runtest/containers b/runtest/containers >>>> index 2637b62fe..863a964ad 100644 >>>> --- a/runtest/containers >>>> +++ b/runtest/containers >>>> @@ -16,7 +16,8 @@ pidns31 pidns31 >>>> pidns32 pidns32 >>>> mqns_01 mqns_01 >>>> -mqns_01_clone mqns_01 -clone >>>> +mqns_01_clone mqns_01 -m clone >>>> +mqns_01_unshare mqns_01 -m unshare >>>> mqns_02 mqns_02 >>>> mqns_02_clone mqns_02 -clone >>>> mqns_03 mqns_03 >>>> diff --git a/testcases/kernel/containers/mqns/common.h b/testcases/kernel/containers/mqns/common.h >>>> new file mode 100644 >>>> index 000000000..92a77b566 >>>> --- /dev/null >>>> +++ b/testcases/kernel/containers/mqns/common.h >>>> @@ -0,0 +1,101 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-or-later >>>> +/* >>>> + * Copyright (C) 2022 SUSE LLC Andrea Cervesato >>>> + */ >>>> + >>>> +#ifndef MQNS_H >>>> +#define MQNS_H >>>> + >>>> +#include >>>> +#include "lapi/namespaces_constants.h" >>>> +#include "tst_test.h" >>>> +#include "tst_safe_posix_ipc.h" >>>> + >>>> +enum { >>>> + T_CLONE, >>>> + T_UNSHARE, >>>> + T_NONE, >>>> +}; >>>> + >>>> +static int dummy_child1(void *v) >>>> +{ >>>> + (void)v; >>>> + return 0; >>>> +} >>>> + >>>> +static inline void check_newipc(void) >>>> +{ >>>> + int pid, status; >>>> + >>>> + pid = ltp_clone_quick(CLONE_NEWIPC | SIGCHLD, dummy_child1, >>>> NULL); >>> ltp_clone_quick is still part of the old API and only uses clone2. I >>> think it should be replaced with tst_clone. This may require extending >>> tst_clone. In fact we probably need a test variant to switch between the >>> clone2 and clone3 syscalls when using tst_clone. >>> >>> I'll leave it to you whether you want to try that and rebase this patch >>> set on it. >>> >> I see ltp_clone_quick as wrapper of ltp_clone, since it's using >> ltp_alloc_stack without calling it explicitly all the times before >> ltp_clone. > > ltp_clone is also part of the old API. At some point we should remove > that. I'm marking this as changes requested. tst_clone should be made to support this scenario. -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp