From: Richard Palethorpe <rpalethorpe@suse.de>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] statx07: umount before un-export
Date: Thu, 22 Dec 2022 09:31:13 +0000 [thread overview]
Message-ID: <87edsrss2d.fsf@suse.de> (raw)
In-Reply-To: <20221221075821.3786392-1-jencce.kernel@gmail.com>
Hello,
Murphy Zhou <jencce.kernel@gmail.com> writes:
> We need to umount first, or there will be an umounted mountpoint
> left behind.
Merged, thanks!
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
> ---
> testcases/kernel/syscalls/statx/statx07.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/statx/statx07.c b/testcases/kernel/syscalls/statx/statx07.c
> index e1ae36a35..8cb3e9b6d 100644
> --- a/testcases/kernel/syscalls/statx/statx07.c
> +++ b/testcases/kernel/syscalls/statx/statx07.c
> @@ -149,6 +149,9 @@ static void setup(void)
>
> static void cleanup(void)
> {
> + if (mounted)
> + SAFE_UMOUNT(CLI_PATH);
> +
> if (!exported)
> return;
> snprintf(cmd, sizeof(cmd),
> @@ -156,9 +159,6 @@ static void cleanup(void)
>
> if (tst_system(cmd) == -1)
> tst_res(TWARN | TST_ERR, "failed to clear exportfs");
> -
> - if (mounted)
> - SAFE_UMOUNT(CLI_PATH);
> }
>
> static struct tst_test test = {
> --
> 2.31.1
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-12-22 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 7:58 [LTP] [PATCH] statx07: umount before un-export Murphy Zhou
2022-12-22 9:31 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edsrss2d.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=jencce.kernel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox