From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CAF3C433EF for ; Mon, 11 Jul 2022 06:03:19 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CB22D3CA625 for ; Mon, 11 Jul 2022 08:03:16 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0A0983C282E for ; Mon, 11 Jul 2022 08:03:06 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id DAF35140075D for ; Mon, 11 Jul 2022 08:03:05 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 2903C1FE38 for ; Mon, 11 Jul 2022 06:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657519385; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SyCy8GVyZg3UTlwaptyfO9JTUsAOJasyX+byT8QP4FE=; b=lA9kg1Kc8rUAD2OSh1+rLBgMMmj3mrcJt2XcmUx5aX99BSG3gU/X3ukMBFafBEL6NGN+9y /Jo8zx7HaVsYpfrFS3trdYyExCV8r2CZycJ6eu1+ZbL5CaTS70vH9947FD/IYsDqtHhm9I tjaBMYhEhu8+WtLH5GGKtU2vBkrFe3U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657519385; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SyCy8GVyZg3UTlwaptyfO9JTUsAOJasyX+byT8QP4FE=; b=oyL8q4rkedOtUbcoNMUGHTfaviVAiWR9t0w20Dh94dklf76Zb36vmFQnqN9DKC98Y3rqma NlRZErW+eik2hcDQ== Received: from g78 (unknown [10.163.24.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D866A2C141; Mon, 11 Jul 2022 06:03:04 +0000 (UTC) References: <20220707110319.24665-1-akumar@suse.de> <20220707110319.24665-2-akumar@suse.de> User-agent: mu4e 1.6.10; emacs 28.1 From: Richard Palethorpe To: Avinesh Kumar Date: Mon, 11 Jul 2022 06:30:20 +0100 In-reply-to: <20220707110319.24665-2-akumar@suse.de> Message-ID: <87edysp4o7.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/9] Rewrite rename01.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, Avinesh Kumar writes: > Signed-off-by: Avinesh Kumar > --- > testcases/kernel/syscalls/rename/rename01.c | 259 +++++--------------- > 1 file changed, 58 insertions(+), 201 deletions(-) > > diff --git a/testcases/kernel/syscalls/rename/rename01.c b/testcases/kernel/syscalls/rename/rename01.c > index e7de18ff4..695d85c57 100644 > --- a/testcases/kernel/syscalls/rename/rename01.c > +++ b/testcases/kernel/syscalls/rename/rename01.c > @@ -1,218 +1,75 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > /* > - * > - * Copyright (c) International Business Machines Corp., 2001 > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See > - * the GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + * Copyright (c) International Business Machines Corp., 2001 > + * 07/2001 Ported by Wayne Boyer > + * Copyright (c) 2022 SUSE LLC Avinesh Kumar > */ > > -/* > - * NAME > - * rename01 > - * > - * DESCRIPTION > - * This test will verify the rename(2) syscall basic functionality. > - * Verify rename() works when the "new" file or directory does not exist. > +/*\ > + * [Description] > * > - * ALGORITHM > - * Setup: > - * Setup signal handling. > - * Create temporary directory. > - * Pause for SIGUSR1 if option specified. > - * > - * Test: > - * Loop if the proper options are given. > - * 1. "old" is plain file, new does not exists > - * create the "old" file, make sure the "new" file > - * dose not exist > - * rename the "old" to the "new" file > - * verify the "new" file points to the "old" file > - * verify the "old" file does not exist > - * > - * 2. "old" is a directory,"new" does not exists > - * create the "old" directory, make sure "new" > - * dose not exist > - * rename the "old" to the "new" > - * verify the "new" points to the "old" > - * verify the "old" does not exist > - * Cleanup: > - * Print errno log and/or timing stats if options given > - * Delete the temporary directory created. > - * > - * USAGE > - * rename01 [-c n] [-f] [-i n] [-I x] [-P x] [-t] > - * where, -c n : Run n copies concurrently. > - * -f : Turn off functionality Testing. > - * -i n : Execute test n times. > - * -I x : Execute test for x seconds. > - * -P x : Pause for x seconds between iterations. > - * -t : Turn on syscall timing. > - * > - * HISTORY > - * 07/2001 Ported by Wayne Boyer > - * > - * RESTRICTIONS > - * None. > + * Verify rename() when the newpath file or directory does not exist. > */ > -#include > -#include > -#include > -#include > -#include > > -#include "test.h" > -#include "safe_macros.h" > - > -void setup(); > -void cleanup(); > +#include > +#include > +#include "tst_test.h" > > -char *TCID = "rename01"; > -int TST_TOTAL = 2; > +#define SWAP(a, b) do { \ > + const char *tmp__ = a; \ > + a = b; \ > + b = tmp__; \ > +} while (0) This doesn't need to be a macro (which don't have type or name collision checking and confuse some tooling etc.). It's actually the same number of lines to write it inline as well, i.e. char *tmp; tmp = a; a = b; b = tmp; tmp = c; c = d; d = tmp; However if you don't want to write it inline I'd prefer a function which takes const *const *char. Otherwise looks good. -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp