From: Richard Palethorpe <rpalethorpe@suse.de>
To: Joerg Vehlow <lkml@jv-coder.de>
Cc: Joerg Vehlow <joerg.vehlow@aox-tech.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] cpuset_regression_test: Fix test, if cpuset groups exist already
Date: Mon, 10 Jan 2022 11:57:12 +0000 [thread overview]
Message-ID: <87ee5f247c.fsf@suse.de> (raw)
In-Reply-To: <4b61c5e9-0976-9e5c-543f-f0ad29307b24@jv-coder.de>
Hello,
Joerg Vehlow <lkml@jv-coder.de> writes:
> Hi,
>
>
> Am 11/24/2021 um 9:24 AM schrieb Richard Palethorpe:
>> Hello Joerg,
>> Joerg Vehlow <lkml@jv-coder.de> writes:
>>
>>> From: Joerg Vehlow <joerg.vehlow@aox-tech.de>
>>>
>>> Fix three errors:
>>> 1. read -d is not posix, but not even required,
>>> because find and read work line-based
>>> 2. Setting cpuset.cpus to an empty string is not allowed.
>>> -> If there are cpuset groups defined already, we need at least two cpus.
>>> One is used for the test, the other one is used for existing groups.
>>> 3. Existing cgroup hierarchies were not handled correctly.
>>> When setting the cpuset.cpus, it must be done first for parent groups,
>>> otherwise cpu constraints for can be violated.
>>>
>>> Fixes: 6950e96eabb2 ("cpuset_regression_test: Allow running, if groups exist")
>>> Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
>> Looks Good!
>> Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
>>
>
> a little ping for merging this
>
> Joerg
Thanks, pushed!
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-01-10 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:04 [LTP] [PATCH v2] cpuset_regression_test: Fix test, if cpuset groups exist already Joerg Vehlow
2021-11-24 8:24 ` Richard Palethorpe
2022-01-10 11:00 ` Joerg Vehlow
2022-01-10 11:57 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee5f247c.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=joerg.vehlow@aox-tech.de \
--cc=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox