* [LTP] [PATCH 0/3] NFS test fixes
@ 2023-09-19 11:46 Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
` (2 more replies)
0 siblings, 3 replies; 21+ messages in thread
From: Martin Doucha @ 2023-09-19 11:46 UTC (permalink / raw)
To: ltp
The nfs03.sh test has a race condition which may randomly cause NFS unmount
to fail and trigger strange behavior. Add NFS mount/unmount logging and
unmount success check for easier debugging. Also fix the race condition
in nfs03.sh
Patch 3 should be merged after new LTP release.
Martin Doucha (3):
nfs_lib.sh: Log NFS mount and unmount
nfs03.sh: Wait for all files to be removed
nfs_lib.sh: Fail the test if NFS unmount fails
testcases/network/nfs/nfs_stress/nfs03.sh | 2 ++
testcases/network/nfs/nfs_stress/nfs_lib.sh | 9 +++++++--
2 files changed, 9 insertions(+), 2 deletions(-)
--
2.42.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread* [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
@ 2023-09-19 11:46 ` Martin Doucha
2023-09-20 7:59 ` Petr Vorel
` (2 more replies)
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2 siblings, 3 replies; 21+ messages in thread
From: Martin Doucha @ 2023-09-19 11:46 UTC (permalink / raw)
To: ltp
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/network/nfs/nfs_stress/nfs_lib.sh | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
index abf7ba5a2..a996f7cc8 100644
--- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
+++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
@@ -191,7 +191,9 @@ nfs_setup()
remote_dir="$(get_remote_dir $i $type)"
nfs_setup_server "$remote_dir" "$(($$ + n))"
- nfs_mount "$(get_local_dir $i $n)" "$remote_dir" "-o proto=$type,vers=$i"
+ local_dir="$(get_local_dir $i $n)"
+ tst_res TINFO "Mounting $local_dir"
+ nfs_mount "$local_dir" "$remote_dir" "-o proto=$type,vers=$i"
n=$(( n + 1 ))
done
@@ -210,7 +212,10 @@ nfs_cleanup()
local n=0
for i in $VERSION; do
local_dir="$(get_local_dir $i $n)"
- grep -q "$local_dir" /proc/mounts && umount $local_dir
+ if grep -q "$local_dir" /proc/mounts; then
+ tst_res TINFO "Unmounting $local_dir"
+ umount $local_dir
+ fi
n=$(( n + 1 ))
done
sleep 2
--
2.42.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
@ 2023-09-20 7:59 ` Petr Vorel
2023-09-20 11:26 ` Richard Palethorpe
2023-09-22 12:02 ` Cyril Hrubis
2 siblings, 0 replies; 21+ messages in thread
From: Petr Vorel @ 2023-09-20 7:59 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi Martin,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-20 7:59 ` Petr Vorel
@ 2023-09-20 11:26 ` Richard Palethorpe
2023-09-22 12:02 ` Cyril Hrubis
2 siblings, 0 replies; 21+ messages in thread
From: Richard Palethorpe @ 2023-09-20 11:26 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
Martin Doucha <mdoucha@suse.cz> writes:
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index abf7ba5a2..a996f7cc8 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -191,7 +191,9 @@ nfs_setup()
>
> remote_dir="$(get_remote_dir $i $type)"
> nfs_setup_server "$remote_dir" "$(($$ + n))"
> - nfs_mount "$(get_local_dir $i $n)" "$remote_dir" "-o proto=$type,vers=$i"
> + local_dir="$(get_local_dir $i $n)"
> + tst_res TINFO "Mounting $local_dir"
> + nfs_mount "$local_dir" "$remote_dir" "-o proto=$type,vers=$i"
>
> n=$(( n + 1 ))
> done
> @@ -210,7 +212,10 @@ nfs_cleanup()
> local n=0
> for i in $VERSION; do
> local_dir="$(get_local_dir $i $n)"
> - grep -q "$local_dir" /proc/mounts && umount $local_dir
> + if grep -q "$local_dir" /proc/mounts; then
> + tst_res TINFO "Unmounting $local_dir"
> + umount $local_dir
> + fi
> n=$(( n + 1 ))
> done
> sleep 2
> --
> 2.42.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-20 7:59 ` Petr Vorel
2023-09-20 11:26 ` Richard Palethorpe
@ 2023-09-22 12:02 ` Cyril Hrubis
2 siblings, 0 replies; 21+ messages in thread
From: Cyril Hrubis @ 2023-09-22 12:02 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
@ 2023-09-19 11:46 ` Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
` (3 more replies)
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2 siblings, 4 replies; 21+ messages in thread
From: Martin Doucha @ 2023-09-19 11:46 UTC (permalink / raw)
To: ltp
A race condition between the two parallel calls of rm_files may cause
NFS unmount to fail and then the NFS client will get confused by remote
filesystem change which leads to strange failures. Make sure both
rm_files calls finish before returning from the main test function.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/network/nfs/nfs_stress/nfs03.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testcases/network/nfs/nfs_stress/nfs03.sh b/testcases/network/nfs/nfs_stress/nfs03.sh
index e5f4de67c..e9ef5fb78 100755
--- a/testcases/network/nfs/nfs_stress/nfs03.sh
+++ b/testcases/network/nfs/nfs_stress/nfs03.sh
@@ -66,11 +66,13 @@ do_test()
cd ../dir1
wait $pid1
rm_files &
+ pid3=$!
tst_res TINFO "cd dir2 & removing files"
cd ../dir2
wait $pid2
rm_files
+ wait $pid3
tst_res TPASS "test done"
}
--
2.42.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
@ 2023-09-20 7:59 ` Richard Palethorpe
2023-09-20 10:50 ` Martin Doucha
2023-09-20 8:00 ` Petr Vorel
` (2 subsequent siblings)
3 siblings, 1 reply; 21+ messages in thread
From: Richard Palethorpe @ 2023-09-20 7:59 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hello,
Martin Doucha <mdoucha@suse.cz> writes:
> A race condition between the two parallel calls of rm_files may cause
> NFS unmount to fail and then the NFS client will get confused by remote
> filesystem change which leads to strange failures. Make sure both
> rm_files calls finish before returning from the main test function.
You mean unmounting fails if there are still operations in progress?
Like does umount fail with EBUSY?
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs03.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs03.sh b/testcases/network/nfs/nfs_stress/nfs03.sh
> index e5f4de67c..e9ef5fb78 100755
> --- a/testcases/network/nfs/nfs_stress/nfs03.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs03.sh
> @@ -66,11 +66,13 @@ do_test()
> cd ../dir1
> wait $pid1
> rm_files &
> + pid3=$!
>
> tst_res TINFO "cd dir2 & removing files"
> cd ../dir2
> wait $pid2
> rm_files
> + wait $pid3
>
> tst_res TPASS "test done"
> }
> --
> 2.42.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
2023-09-20 7:59 ` Richard Palethorpe
@ 2023-09-20 10:50 ` Martin Doucha
0 siblings, 0 replies; 21+ messages in thread
From: Martin Doucha @ 2023-09-20 10:50 UTC (permalink / raw)
To: rpalethorpe; +Cc: ltp
On 20. 09. 23 9:59, Richard Palethorpe wrote:
> Hello,
>
> Martin Doucha <mdoucha@suse.cz> writes:
>
>> A race condition between the two parallel calls of rm_files may cause
>> NFS unmount to fail and then the NFS client will get confused by remote
>> filesystem change which leads to strange failures. Make sure both
>> rm_files calls finish before returning from the main test function.
>
> You mean unmounting fails if there are still operations in progress?
>
> Like does umount fail with EBUSY?
Yes, the unmount will fail with EBUSY. Then the test filesystem gets
deleted while still mounted over NFS and a new NFS mount gets added on
top. Then the NFS client randomly gets confused and complains about fsid
change.
>
>>
>> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
>> ---
>> testcases/network/nfs/nfs_stress/nfs03.sh | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/testcases/network/nfs/nfs_stress/nfs03.sh b/testcases/network/nfs/nfs_stress/nfs03.sh
>> index e5f4de67c..e9ef5fb78 100755
>> --- a/testcases/network/nfs/nfs_stress/nfs03.sh
>> +++ b/testcases/network/nfs/nfs_stress/nfs03.sh
>> @@ -66,11 +66,13 @@ do_test()
>> cd ../dir1
>> wait $pid1
>> rm_files &
>> + pid3=$!
>>
>> tst_res TINFO "cd dir2 & removing files"
>> cd ../dir2
>> wait $pid2
>> rm_files
>> + wait $pid3
>>
>> tst_res TPASS "test done"
>> }
>> --
>> 2.42.0
>
>
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
@ 2023-09-20 8:00 ` Petr Vorel
2023-09-20 11:28 ` Richard Palethorpe
2023-09-22 12:05 ` Cyril Hrubis
3 siblings, 0 replies; 21+ messages in thread
From: Petr Vorel @ 2023-09-20 8:00 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi Martin,
Good idea, if the test timeouts we know it's due removing files.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
2023-09-20 8:00 ` Petr Vorel
@ 2023-09-20 11:28 ` Richard Palethorpe
2023-09-22 12:05 ` Cyril Hrubis
3 siblings, 0 replies; 21+ messages in thread
From: Richard Palethorpe @ 2023-09-20 11:28 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
Martin Doucha <mdoucha@suse.cz> writes:
> A race condition between the two parallel calls of rm_files may cause
> NFS unmount to fail and then the NFS client will get confused by remote
> filesystem change which leads to strange failures. Make sure both
> rm_files calls finish before returning from the main test function.
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs03.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs03.sh b/testcases/network/nfs/nfs_stress/nfs03.sh
> index e5f4de67c..e9ef5fb78 100755
> --- a/testcases/network/nfs/nfs_stress/nfs03.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs03.sh
> @@ -66,11 +66,13 @@ do_test()
> cd ../dir1
> wait $pid1
> rm_files &
> + pid3=$!
>
> tst_res TINFO "cd dir2 & removing files"
> cd ../dir2
> wait $pid2
> rm_files
> + wait $pid3
>
> tst_res TPASS "test done"
> }
> --
> 2.42.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
` (2 preceding siblings ...)
2023-09-20 11:28 ` Richard Palethorpe
@ 2023-09-22 12:05 ` Cyril Hrubis
2023-09-25 13:22 ` Petr Vorel
3 siblings, 1 reply; 21+ messages in thread
From: Cyril Hrubis @ 2023-09-22 12:05 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
@ 2023-09-19 11:46 ` Martin Doucha
2023-09-20 8:01 ` Petr Vorel
` (2 more replies)
2 siblings, 3 replies; 21+ messages in thread
From: Martin Doucha @ 2023-09-19 11:46 UTC (permalink / raw)
To: ltp
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
index a996f7cc8..099c78759 100644
--- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
+++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
@@ -214,7 +214,7 @@ nfs_cleanup()
local_dir="$(get_local_dir $i $n)"
if grep -q "$local_dir" /proc/mounts; then
tst_res TINFO "Unmounting $local_dir"
- umount $local_dir
+ umount $local_dir || tst_res TFAIL "Unmount failed"
fi
n=$(( n + 1 ))
done
--
2.42.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
@ 2023-09-20 8:01 ` Petr Vorel
2023-09-20 11:27 ` Richard Palethorpe
2023-09-22 12:08 ` Cyril Hrubis
2 siblings, 0 replies; 21+ messages in thread
From: Petr Vorel @ 2023-09-20 8:01 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi Martin,
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index a996f7cc8..099c78759 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -214,7 +214,7 @@ nfs_cleanup()
> local_dir="$(get_local_dir $i $n)"
> if grep -q "$local_dir" /proc/mounts; then
> tst_res TINFO "Unmounting $local_dir"
> - umount $local_dir
> + umount $local_dir || tst_res TFAIL "Unmount failed"
I'd personally add TWARN (i.e. less critical error).
@Cyril WDYT?
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> fi
> n=$(( n + 1 ))
> done
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2023-09-20 8:01 ` Petr Vorel
@ 2023-09-20 11:27 ` Richard Palethorpe
2023-09-22 12:08 ` Cyril Hrubis
2 siblings, 0 replies; 21+ messages in thread
From: Richard Palethorpe @ 2023-09-20 11:27 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
Martin Doucha <mdoucha@suse.cz> writes:
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index a996f7cc8..099c78759 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -214,7 +214,7 @@ nfs_cleanup()
> local_dir="$(get_local_dir $i $n)"
> if grep -q "$local_dir" /proc/mounts; then
> tst_res TINFO "Unmounting $local_dir"
> - umount $local_dir
> + umount $local_dir || tst_res TFAIL "Unmount failed"
> fi
> n=$(( n + 1 ))
> done
> --
> 2.42.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2023-09-20 8:01 ` Petr Vorel
2023-09-20 11:27 ` Richard Palethorpe
@ 2023-09-22 12:08 ` Cyril Hrubis
2023-09-25 13:24 ` Petr Vorel
2 siblings, 1 reply; 21+ messages in thread
From: Cyril Hrubis @ 2023-09-22 12:08 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi!
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index a996f7cc8..099c78759 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -214,7 +214,7 @@ nfs_cleanup()
> local_dir="$(get_local_dir $i $n)"
> if grep -q "$local_dir" /proc/mounts; then
> tst_res TINFO "Unmounting $local_dir"
> - umount $local_dir
> + umount $local_dir || tst_res TFAIL "Unmount failed"
I suppose that this should be TBROK instead. And that this, apart from
the previous patches, should be applied after the release.
Otherwise:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-22 12:08 ` Cyril Hrubis
@ 2023-09-25 13:24 ` Petr Vorel
2023-09-25 13:45 ` Martin Doucha
0 siblings, 1 reply; 21+ messages in thread
From: Petr Vorel @ 2023-09-25 13:24 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
> Hi!
> > diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > index a996f7cc8..099c78759 100644
> > --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > @@ -214,7 +214,7 @@ nfs_cleanup()
> > local_dir="$(get_local_dir $i $n)"
> > if grep -q "$local_dir" /proc/mounts; then
> > tst_res TINFO "Unmounting $local_dir"
> > - umount $local_dir
> > + umount $local_dir || tst_res TFAIL "Unmount failed"
> I suppose that this should be TBROK instead. And that this, apart from
Right, TBROK looks to be the best.
Martin, if you're ok with the change, I'll update it before merge (after the
release).
Kind regards,
Petr
> the previous patches, should be applied after the release.
> Otherwise:
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-25 13:24 ` Petr Vorel
@ 2023-09-25 13:45 ` Martin Doucha
2023-09-25 17:40 ` Petr Vorel
0 siblings, 1 reply; 21+ messages in thread
From: Martin Doucha @ 2023-09-25 13:45 UTC (permalink / raw)
To: Petr Vorel, Cyril Hrubis; +Cc: ltp
On 25. 09. 23 15:24, Petr Vorel wrote:
>> Hi!
>>> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
>>> index a996f7cc8..099c78759 100644
>>> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
>>> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
>>> @@ -214,7 +214,7 @@ nfs_cleanup()
>>> local_dir="$(get_local_dir $i $n)"
>>> if grep -q "$local_dir" /proc/mounts; then
>>> tst_res TINFO "Unmounting $local_dir"
>>> - umount $local_dir
>>> + umount $local_dir || tst_res TFAIL "Unmount failed"
>
>> I suppose that this should be TBROK instead. And that this, apart from
>
> Right, TBROK looks to be the best.
> Martin, if you're ok with the change, I'll update it before merge (after the
> release).
I don't see the point. This is a cleanup function. The TBROK will be
changed to TWARN and the test will continue anyway.
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-25 13:45 ` Martin Doucha
@ 2023-09-25 17:40 ` Petr Vorel
2023-11-13 15:46 ` Martin Doucha
0 siblings, 1 reply; 21+ messages in thread
From: Petr Vorel @ 2023-09-25 17:40 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi,
...
> > > > - umount $local_dir
> > > > + umount $local_dir || tst_res TFAIL "Unmount failed"
> > > I suppose that this should be TBROK instead. And that this, apart from
> > Right, TBROK looks to be the best.
> > Martin, if you're ok with the change, I'll update it before merge (after the
> > release).
> I don't see the point. This is a cleanup function. The TBROK will be changed
> to TWARN and the test will continue anyway.
But TFAIL in cleanup function looks to me strange as well. Should we endup with
TWARN then?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-09-25 17:40 ` Petr Vorel
@ 2023-11-13 15:46 ` Martin Doucha
2023-11-13 15:49 ` Petr Vorel
0 siblings, 1 reply; 21+ messages in thread
From: Martin Doucha @ 2023-11-13 15:46 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
On 25. 09. 23 19:40, Petr Vorel wrote:
> Hi,
>
> ...
>>>>> - umount $local_dir
>>>>> + umount $local_dir || tst_res TFAIL "Unmount failed"
>
>>>> I suppose that this should be TBROK instead. And that this, apart from
>
>>> Right, TBROK looks to be the best.
>>> Martin, if you're ok with the change, I'll update it before merge (after the
>>> release).
>> I don't see the point. This is a cleanup function. The TBROK will be changed
>> to TWARN and the test will continue anyway.
>
> But TFAIL in cleanup function looks to me strange as well. Should we endup with
> TWARN then?
TWARN makes sense. Feel free to change it during merge.
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
2023-11-13 15:46 ` Martin Doucha
@ 2023-11-13 15:49 ` Petr Vorel
0 siblings, 0 replies; 21+ messages in thread
From: Petr Vorel @ 2023-11-13 15:49 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
> On 25. 09. 23 19:40, Petr Vorel wrote:
> > Hi,
> > ...
> > > > > > - umount $local_dir
> > > > > > + umount $local_dir || tst_res TFAIL "Unmount failed"
> > > > > I suppose that this should be TBROK instead. And that this, apart from
> > > > Right, TBROK looks to be the best.
> > > > Martin, if you're ok with the change, I'll update it before merge (after the
> > > > release).
> > > I don't see the point. This is a cleanup function. The TBROK will be changed
> > > to TWARN and the test will continue anyway.
> > But TFAIL in cleanup function looks to me strange as well. Should we endup with
> > TWARN then?
> TWARN makes sense. Feel free to change it during merge.
Good, changed and merged. Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2023-11-13 15:49 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-20 7:59 ` Petr Vorel
2023-09-20 11:26 ` Richard Palethorpe
2023-09-22 12:02 ` Cyril Hrubis
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
2023-09-20 10:50 ` Martin Doucha
2023-09-20 8:00 ` Petr Vorel
2023-09-20 11:28 ` Richard Palethorpe
2023-09-22 12:05 ` Cyril Hrubis
2023-09-25 13:22 ` Petr Vorel
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2023-09-20 8:01 ` Petr Vorel
2023-09-20 11:27 ` Richard Palethorpe
2023-09-22 12:08 ` Cyril Hrubis
2023-09-25 13:24 ` Petr Vorel
2023-09-25 13:45 ` Martin Doucha
2023-09-25 17:40 ` Petr Vorel
2023-11-13 15:46 ` Martin Doucha
2023-11-13 15:49 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox