From: Richard Palethorpe <rpalethorpe@suse.de>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/mount03: Add statfs f_flags member check
Date: Mon, 24 Oct 2022 15:49:36 +0100 [thread overview]
Message-ID: <87fsfdxol5.fsf@suse.de> (raw)
In-Reply-To: <d4483cf3-d1f9-5314-5e87-3b1edf2820e0@fujitsu.com>
Hello,
"xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com> writes:
> Hi Petr
>
>> Hi Xu,
>>
>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>
>>> static void run(unsigned int n)
>>> {
>>> struct tcase *tc = &tcases[n];
>>> + struct statfs stfs;
>>
>>> tst_res(TINFO, "Testing flag %s", tc->desc);
>>
>>> @@ -159,6 +160,11 @@ static void run(unsigned int n)
>>> if (tc->test)
>>> tc->test();
>>
>>> + SAFE_STATFS(MNTPOINT, &stfs);
>>> + if (stfs.f_flags & (n == 3 ? MS_REMOUNT : tc->flag))
>> Wouldn't it be better to add another struct member for this check?
>
> Of course, it seems better.
>
> Best Regards
> Yang Xu
OK... Petr are you going to merge this with your changes?
Acked-by: Richard Palethorpe <rpalethorpe@suse.com>
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-24 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 11:10 [LTP] [PATCH] syscalls/mount03: Add statfs f_flags member check Yang Xu
2022-10-21 22:13 ` Petr Vorel
2022-10-24 1:20 ` xuyang2018.jy
2022-10-24 14:49 ` Richard Palethorpe [this message]
2022-10-25 2:13 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsfdxol5.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox