From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C0D9C433F5 for ; Mon, 21 Feb 2022 14:15:54 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B14B53CA17A for ; Mon, 21 Feb 2022 15:15:50 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 338DF3C6AD5 for ; Mon, 21 Feb 2022 15:15:39 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 3049A1400759 for ; Mon, 21 Feb 2022 15:15:38 +0100 (CET) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 38E591F38E; Mon, 21 Feb 2022 14:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645452938; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UMbhA1TmP3DHzyiV55nEbdvJkcjIy39w0mu+NnVnyDg=; b=n/YEXXpP9+Hj/s8M/NGx+B65JGg2UlRWJAtu5F2mNq5sVGxg2glPwiFAMTkvRiECsA4Fz9 d2TINWMz49EZOqXoFbr+mShhnvAKX7nxlSO1sCnX18fgkEfqXjv4bA5EjCKTVsMVOGAk1Y YA7pyOmEF/WzW3NqZ9RwrvIIYtVefic= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645452938; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UMbhA1TmP3DHzyiV55nEbdvJkcjIy39w0mu+NnVnyDg=; b=iwh4LC16s5c2c5bSATGgt5bGVijnMaKbQ0eMtn9L1S+o9HsEkJOUK/rtl/bK4hlaKkmpt/ tLyqGhXz+SwMtOAw== Received: from g78 (unknown [10.163.24.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EBC84A3B88; Mon, 21 Feb 2022 14:15:37 +0000 (UTC) References: <1645005868-2373-1-git-send-email-xuyang2018.jy@fujitsu.com> <1645005868-2373-4-git-send-email-xuyang2018.jy@fujitsu.com> <620F118E.3070306@fujitsu.com> <87k0dojy5j.fsf@suse.de> User-agent: mu4e 1.6.10; emacs 27.2 From: Richard Palethorpe To: Petr Vorel Date: Mon, 21 Feb 2022 13:49:04 +0000 In-reply-to: Message-ID: <87fsocjofw.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 4/5] Add pidfd_getfd01 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello Petr, Petr Vorel writes: > Hi Richie, > >> Hello Petr, > >> Petr Vorel writes: > >> > Hi Richie, Xu, > >> >> Hi Petr >> >> > Hi Xu, > >> >> > ... >> >> >> +++ b/testcases/kernel/syscalls/pidfd_getfd/pidfd_getfd01.c >> >> > ... >> >> >> + remotefd = TST_RET; >> >> >> + flag = fcntl(remotefd, F_GETFD); >> >> >> + if (flag == -1) >> >> >> + tst_brk(TFAIL | TERRNO, "fcntl(F_GETFD) failed"); >> >> > Just: >> >> > flag = SAFE_FCNTL(remotefd, F_GETFD); >> >> Yes, I almost forgot we have this macro. >> > @Richie: It'd be useful if sparse checks would suggest to use SAFE_*() >> > functions, but not sure if easily detectable. Something like setup() and >> > cleanup() function and syscall followed by if (foo == -1) followed by tst_brk(). > >> > Kind regards, >> > Petr > >> Yeah, this would be relatively simple in Coccinelle. In Sparse I'm not >> sure, but it is one of the main use cases IMO. > I remember few years ago (2017) metan did big cleanup with Coccinelle. > If much simpler, we might want to introduce some basic scripts (without > vendoring Coccinelle, it'd have to be installed). Indeed, we already have some in scripts/coccinelle. These are mainly useful for refactoring. > >> Hopefully the IR produced by these code patterns is fairly stable. In >> that case we can do some simple pattern matching. > Frankly speaking, if ever implemented it's probably you who is going to > implement it, thus your choice what you use :). > > Kind regards, > Petr Yeah, although it still needs reviewing :-p -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp