Re: [LTP] [PATCH v1 1/2] Ensure prio is within valid range in `rt-migrate.c`

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello,

Marius Kittler <mkittler@suse.de> writes:

> Am Mittwoch, 13. September 2023, 11:11:42 CEST schrieb Andrea Cervesato:
>> Hi!
>> 
>>   I generally suggest to refactor test into new API if a structural
>> change is needed.
>
> That is why I refrained from a structural change and implemented the fix with 
> the minimum amount of change possible. This way the risk of introducing new 
> bugs should be very small and the low "hanging fruit" is grabbed.
>
>> I would suggest to take a look at the code a bit closer and to guess how
>> much effort we should put in order to rewrite it with new API.
>
> I guess it would be doable and if that's wanted I can do that as the next step 
> as a separate commit. Not sure how long it'll take me, maybe a couple of hours 
> or a day (since I'm still new to ltp). (There is no ticket asking about such a 
> refactoring explicitly so I honestly don't know whether it is wanted or 
> whether we should invest our time better elsewhere.)

I merged it and the fix looks good. Thanks!

I'm not sure it is worth applying little fixes to these tests without a
rewrite or investigating wether this test is a duplicate, but it's done
now.

-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp