Re: [LTP] [PATCH v2 2/5] API/cgroup: Declare required controllers and version in test struct

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello Li,

Li Wang <liwang@redhat.com> writes:

> Hi Richard,
>
> This is a good improvement for the CG API. Nice work!!

Thanks.

>
> On Thu, Feb 3, 2022 at 4:20 PM Richard Palethorpe via ltp <ltp@lists.linux.it> wrote:
>
>  ...
>
>  --- a/include/tst_test.h
>  +++ b/include/tst_test.h
>  @@ -133,6 +133,14 @@ extern unsigned int tst_variant;
>
>   #define TST_NO_HUGEPAGES ((unsigned long)-1)
>
>  +/* CGroups Kernel API version */
>  +enum tst_cgroup_ver {
>  +       TST_CGROUP_V1 = 1,
>  +       TST_CGROUP_V2 = 2,
>  +};
>
> We can move this into 'tst_cgroup.h' if included that header in tst_test.h.
>
> (As we decide to integrate the CG structure in tst_test, it
> seems better to include that tst_cgorup.h file though that
> makes some binaries become larger.)

Yes, thinking about it tst_cgroup.h only declares a few symbols now
anyway.

Also agreed with all the other points.

-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp