public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 3/3] tst_fill_fs: Add alternate access pattern "flat"
Date: Mon, 12 Dec 2022 14:47:19 +0000	[thread overview]
Message-ID: <87iligu18f.fsf@suse.de> (raw)
In-Reply-To: <Y5c75/uA9lvmVoqQ@rei>

Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> +enum tst_fill_access_pattern {
>> +	TST_FILL_FLAT_VEC,
>
> Not sure if this is a good name, maybe TST_FILL_BLOCKS or
> TST_FILL_PAGES.

hhmm, OK blocks then.

>
>> +	TST_FILL_RANDOM
>> +};
>
> Otherwise the whole patchset looks good to me.
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Thanks


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-12-12 14:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 13:55 [LTP] [PATCH v2 1/3] lib/tst_rand_data: Add statically defined data pattern Richard Palethorpe via ltp
2022-12-12 13:55 ` [LTP] [PATCH v2 2/3] tst_fill_fs: Ensure data is not easily compressed Richard Palethorpe via ltp
2022-12-12 13:55 ` [LTP] [PATCH v2 3/3] tst_fill_fs: Add alternate access pattern "flat" Richard Palethorpe via ltp
2022-12-12 14:34   ` Cyril Hrubis
2022-12-12 14:47     ` Richard Palethorpe [this message]
2022-12-12 16:09   ` Petr Vorel
2022-12-12 16:16     ` Cyril Hrubis
2022-12-12 16:20       ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iligu18f.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox