From: Richard Palethorpe <rpalethorpe@suse.de>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] setreuid04.c: Rewrite using new LTP API
Date: Mon, 23 Jan 2023 09:30:14 +0000 [thread overview]
Message-ID: <87leltioby.fsf@suse.de> (raw)
In-Reply-To: <20230123064845.13564-1-akumar@suse.de>
Hello,
Avinesh Kumar <akumar@suse.de> writes:
> + TST_EXP_PASS(SETREUID(nobody_uid, nobody_uid));
>
> -static void uid_verify(struct passwd *ru, struct passwd *eu, char *when)
> -{
> - if ((getuid() != ru->pw_uid) || (geteuid() != eu->pw_uid)) {
> - tst_resm(TFAIL, "ERROR: %s real uid = %d; effective uid = %d",
> - when, getuid(), geteuid());
> - tst_resm(TINFO, "Expected: real uid = %d; effective uid = %d",
> - ru->pw_uid, eu->pw_uid);
> + TST_EXP_EQ_LI(getuid(), nobody_uid);
> + TST_EXP_EQ_LI(geteuid(), nobody_uid);
Forgot to use the macros for 16bit UIDS again. However we can fix that
before merge.
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-01-23 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:25 [LTP] [PATCH] setreuid04.c: Rewrite using new LTP API Avinesh Kumar
2023-01-12 0:23 ` Petr Vorel
2023-01-12 10:37 ` Richard Palethorpe
2023-01-16 10:42 ` Richard Palethorpe
2023-01-23 6:48 ` [LTP] [PATCH v2] " Avinesh Kumar
2023-01-23 9:30 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leltioby.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox