From: Richard Palethorpe <rpalethorpe@suse.de>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] Move semaphore/ tests to semop/
Date: Tue, 28 Feb 2023 09:15:19 +0000 [thread overview]
Message-ID: <87mt4yuopq.fsf@suse.de> (raw)
In-Reply-To: <20230120010533.11202-1-wegao@suse.com>
Hello,
Wei Gao via ltp <ltp@lists.linux.it> writes:
> There is no point in having two different directories with semop()
> testcaes so it would make sense to move these two tests into the
> syscalls/ipc/semop/ directory as semop04 and semop05.
> So we move ipc/semaphore/ tests to syscalls/ipc/semop/.
> Also update runtest files accordingly.
Yes, true. However these tests are using the old API. It makes sense to
move them and update to the new API at the same time. Maybe they even
test the same things as the other tests, so they could be deduplicated.
I like breaking things into small tasks, but this is actually too
small. I think it would be better to convert and move one test at a time
as well (in separate commits, but in the same patch series).
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-02-28 9:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 13:25 [LTP] [PATCH v1] Move semaphore/ tests to semop/ Wei Gao via ltp
2023-01-19 18:00 ` Petr Vorel
2023-01-20 1:05 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-02-28 9:15 ` Richard Palethorpe [this message]
2023-03-02 7:15 ` [LTP] [PATCH v3 0/2] Refactor semaphore Wei Gao via ltp
2023-03-02 7:15 ` [LTP] [PATCH v3 1/2] Move semaphore/ tests to semop/ Wei Gao via ltp
2023-03-15 12:31 ` Petr Vorel
2023-03-15 13:11 ` Wei Gao via ltp
2023-03-15 17:47 ` Petr Vorel
2023-03-17 12:29 ` Li Wang
2023-03-19 17:05 ` Petr Vorel
2023-03-02 7:15 ` [LTP] [PATCH v3 2/2] semop04:Refactor with new API Wei Gao via ltp
2023-03-15 12:36 ` Petr Vorel
2023-03-15 13:03 ` Wei Gao via ltp
2023-03-15 18:39 ` Petr Vorel
2023-03-16 7:22 ` [LTP] [PATCH v4 0/2] Refactor semaphore Wei Gao via ltp
2023-03-16 7:22 ` [LTP] [PATCH v4 1/2] Move semaphore/ tests to semop/ Wei Gao via ltp
2023-03-16 7:22 ` [LTP] [PATCH v4 2/2] semop04:Refactor with new API Wei Gao via ltp
2023-05-29 18:34 ` Petr Vorel
2023-05-30 12:07 ` [LTP] [v5,2/2] semop04: Refactor " Wei Gao via ltp
2023-06-21 10:25 ` Petr Vorel
2023-08-29 9:20 ` Richard Palethorpe
2023-08-29 11:00 ` [LTP] [v6,2/2] " Wei Gao via ltp
2023-08-29 11:18 ` [LTP] [v7,2/2] " Wei Gao via ltp
2023-08-30 11:41 ` Andrea Cervesato via ltp
2023-09-01 7:38 ` Richard Palethorpe
2023-09-02 11:32 ` [LTP] [PATCH v8] " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt4yuopq.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox