From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B16EAC63797 for ; Tue, 10 Jan 2023 14:20:33 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D40803CCB27 for ; Tue, 10 Jan 2023 15:20:31 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id A2C443CA6C2 for ; Tue, 10 Jan 2023 15:20:22 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 0DEE26005FC for ; Tue, 10 Jan 2023 15:20:21 +0100 (CET) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 00C7F77029 for ; Tue, 10 Jan 2023 14:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673360421; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OPB+ki0dXvnzqeySE5ARXdEYRZaNwUh8ltDjf8AwZ5Q=; b=Uj1aKFznr0N6TQaHEz2Q3jX1HBLVfSiQIwmj2Kr8pYtDet70RiYw2t27PuS0d18/SjXn1e FIbCrtJCSAzk0f6W84K7C/F0wmtFrND+L2u3CEyCf1Vwt/XQrxb+vUn3r5Ce7WnYu38Nq0 p0qUpz7Lxr6XTf/0VplAdWTEO9BkKN8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673360421; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OPB+ki0dXvnzqeySE5ARXdEYRZaNwUh8ltDjf8AwZ5Q=; b=wNl9S0LEV/mfqT4yBH5C0latFlJzFFpzP/nZ4AQ0Li1+fVSp412rUVHIE63z9VM0SwVMom usoK2QbZAvq0k/DQ== Received: from g78 (rpalethorpe.tcp.ovpn1.nue.suse.de [10.163.17.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 17A252C141; Tue, 10 Jan 2023 14:20:19 +0000 (UTC) References: <20230110130711.29274-1-akumar@suse.de> User-agent: mu4e 1.8.13; emacs 28.2 From: Richard Palethorpe To: Avinesh Kumar Date: Tue, 10 Jan 2023 14:20:14 +0000 Organization: Linux Private Site In-reply-to: <20230110130711.29274-1-akumar@suse.de> Message-ID: <87mt6qh3oc.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] setreuid01: Use SETREUID() instead of setreuid() to check 32bit syscall X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, Merged, thanks! Avinesh Kumar writes: > Signed-off-by: Avinesh Kumar > --- > testcases/kernel/syscalls/setreuid/setreuid01.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/testcases/kernel/syscalls/setreuid/setreuid01.c b/testcases/kernel/syscalls/setreuid/setreuid01.c > index bbf29d360..7c2b6d589 100644 > --- a/testcases/kernel/syscalls/setreuid/setreuid01.c > +++ b/testcases/kernel/syscalls/setreuid/setreuid01.c > @@ -26,13 +26,13 @@ static void run(void) > euid = geteuid(); > UID16_CHECK(euid, setreuid); > > - TST_EXP_PASS(setreuid(-1, -1)); > - TST_EXP_PASS(setreuid(-1, euid)); > - TST_EXP_PASS(setreuid(ruid, -1)); > - TST_EXP_PASS(setreuid(-1, ruid)); > - TST_EXP_PASS(setreuid(euid, -1)); > - TST_EXP_PASS(setreuid(euid, euid)); > - TST_EXP_PASS(setreuid(ruid, ruid)); > + TST_EXP_PASS(SETREUID(-1, -1)); > + TST_EXP_PASS(SETREUID(-1, euid)); > + TST_EXP_PASS(SETREUID(ruid, -1)); > + TST_EXP_PASS(SETREUID(-1, ruid)); > + TST_EXP_PASS(SETREUID(euid, -1)); > + TST_EXP_PASS(SETREUID(euid, euid)); > + TST_EXP_PASS(SETREUID(ruid, ruid)); > } > > static struct tst_test test = { > -- > 2.39.0 -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp