public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Tudor Cretu <tudor.cretu@arm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] build.sh: Allow specifying additional make options
Date: Tue, 11 Oct 2022 15:43:16 +0100	[thread overview]
Message-ID: <87o7ui5se0.fsf@suse.de> (raw)
In-Reply-To: <20220817133929.234873-3-tudor.cretu@arm.com>

Hello,

Tudor Cretu <tudor.cretu@arm.com> writes:

> This enables build.sh to use make options such as TST_NEWER_64_SYSCALL or
> TST_COMPAT_16_SYSCALL, e.g.:
>
> MAKE_OPTS="TST_NEWER_64_SYSCALL=no TST_COMPAT_16_SYSCALL=no"
> ./build.sh ...

I'm not sure if you still want this one or not after the other patch was
dropped. In any case Petr seems to favor command line args (with docs)
over env variables. So it would be best to stick to the existing style
of this script.

>
> Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
> ---
>  build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.sh b/build.sh
> index 1767cc21b..42c89ad97 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -18,7 +18,7 @@ CONFIGURE_OPTS_OUT_TREE="--with-realtime-testsuite $CONFIGURE_OPT_EXTRA"
>  SRC_DIR="$(cd $(dirname $0); pwd)"
>  BUILD_DIR="$SRC_DIR/../ltp-build"
>  
> -MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN)"
> +MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN) $MAKE_OPTS"
>  MAKE_OPTS_OUT_TREE="$MAKE_OPTS -C $BUILD_DIR -f $SRC_DIR/Makefile top_srcdir=$SRC_DIR top_builddir=$BUILD_DIR"
>  
>  run_configure()
> -- 
> 2.25.1


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-10-11 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 13:39 [LTP] [PATCH 0/2] utils/compat_16: Allow build.sh to disable the compat_16 tests Tudor Cretu
2022-08-17 13:39 ` [LTP] [PATCH 1/2] utils/compat_16: Add a make option to disable the build of " Tudor Cretu
2022-08-17 13:39 ` [LTP] [PATCH 2/2] build.sh: Allow specifying additional make options Tudor Cretu
2022-10-11 14:43   ` Richard Palethorpe [this message]
2022-08-17 14:09 ` [LTP] [PATCH 0/2] utils/compat_16: Allow build.sh to disable the compat_16 tests Cyril Hrubis
2022-08-17 14:49   ` Tudor Cretu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7ui5se0.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    --cc=tudor.cretu@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox