[LTP] [PATCH 0/2] utils/compat_16: Allow build.sh to disable the compat_16 tests

[LTP] [PATCH 0/2] utils/compat_16: Allow build.sh to disable the compat_16 tests

[Tudor Cretu]

Hi,

The option that allows disabling the compat_16 tests has been erroneously
removed in a previous change, so re-add it. Also, enable build.sh to use
make options such as TST_NEWER_64_SYSCALL or TST_COMPAT_16_SYSCALL.

Tudor Cretu (2):
  utils/compat_16: Add a make option to disable the build of compat_16
    tests.
  build.sh: Allow specifying additional make options

 build.sh                                     | 2 +-
 testcases/kernel/syscalls/utils/compat_16.mk | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.25.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/2] utils/compat_16: Add a make option to disable the build of compat_16 tests.

[Tudor Cretu]

utils/newer_64.mk has a make option that disables the build of newer_64
tests. Similarly, add a make option to utils/compat_16.mk to disable the
build of compat_16 tests.

Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
---
 testcases/kernel/syscalls/utils/compat_16.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/syscalls/utils/compat_16.mk b/testcases/kernel/syscalls/utils/compat_16.mk
index e81a00c40..71fcc4b89 100644
--- a/testcases/kernel/syscalls/utils/compat_16.mk
+++ b/testcases/kernel/syscalls/utils/compat_16.mk
@@ -54,7 +54,9 @@ SRCS			?= $(sort $(wildcard $(abs_srcdir)/*.c))
 
 MAKE_TARGETS		:= $(notdir $(patsubst %.c,%,$(SRCS)))
 MAKE_TARGETS_OBJS_WO_COMPAT_16	:= $(addsuffix .o,$(MAKE_TARGETS))
+ifneq ($(TST_COMPAT_16_SYSCALL),no)
 MAKE_TARGETS		+= $(addsuffix _16,$(MAKE_TARGETS))
+endif
 
 # XXX (garrcoop): This code should be put in question as it cannot be applied
 # (no .h file, no TST_USE_NEWER64_SYSCALL def).
-- 
2.25.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 2/2] build.sh: Allow specifying additional make options

[Tudor Cretu]

This enables build.sh to use make options such as TST_NEWER_64_SYSCALL or
TST_COMPAT_16_SYSCALL, e.g.:

MAKE_OPTS="TST_NEWER_64_SYSCALL=no TST_COMPAT_16_SYSCALL=no" ./build.sh ...

Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
---
 build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build.sh b/build.sh
index 1767cc21b..42c89ad97 100755
--- a/build.sh
+++ b/build.sh
@@ -18,7 +18,7 @@ CONFIGURE_OPTS_OUT_TREE="--with-realtime-testsuite $CONFIGURE_OPT_EXTRA"
 SRC_DIR="$(cd $(dirname $0); pwd)"
 BUILD_DIR="$SRC_DIR/../ltp-build"
 
-MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN)"
+MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN) $MAKE_OPTS"
 MAKE_OPTS_OUT_TREE="$MAKE_OPTS -C $BUILD_DIR -f $SRC_DIR/Makefile top_srcdir=$SRC_DIR top_builddir=$BUILD_DIR"
 
 run_configure()
-- 
2.25.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 0/2] utils/compat_16: Allow build.sh to disable the compat_16 tests

[Cyril Hrubis]

Hi!
> The option that allows disabling the compat_16 tests has been erroneously
> removed in a previous change, so re-add it. Also, enable build.sh to use
> make options such as TST_NEWER_64_SYSCALL or TST_COMPAT_16_SYSCALL.

It does not seem to be removed erroneously. What problem are you trying
to solve?

Generally we rather produce tests that then return with TCONF (skipped)
status than disable them from compilation.

If you want to skip them at runtime you can filter them out from the
rutnest files.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 0/2] utils/compat_16: Allow build.sh to disable the compat_16 tests

[Tudor Cretu]

Hi!

On 17-08-2022 15:09, Cyril Hrubis wrote:
> Hi!
>> The option that allows disabling the compat_16 tests has been erroneously
>> removed in a previous change, so re-add it. Also, enable build.sh to use
>> make options such as TST_NEWER_64_SYSCALL or TST_COMPAT_16_SYSCALL.
>
> It does not seem to be removed erroneously. What problem are you trying
> to solve?

I'm sorry, I think "erroneously" wasn't the right word indeed. In my
usecase, I cross-compile the kernel/syscalls tests for AArch64 and send
the output over the network. Not compiling the newer_64 and compat_16
tests reduces the total size of the LTP syscalls tests binaries folder
by about 20%, which was convenient.

>
> Generally we rather produce tests that then return with TCONF (skipped)
> status than disable them from compilation.

In this case, I agree there is not much incentive for this change and
I'm happy to drop it.

>
> If you want to skip them at runtime you can filter them out from the
> rutnest files.
>

Thanks,
Tudor
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] build.sh: Allow specifying additional make options

[Richard Palethorpe]

Hello,

Tudor Cretu <tudor.cretu@arm.com> writes:

> This enables build.sh to use make options such as TST_NEWER_64_SYSCALL or
> TST_COMPAT_16_SYSCALL, e.g.:
>
> MAKE_OPTS="TST_NEWER_64_SYSCALL=no TST_COMPAT_16_SYSCALL=no"
> ./build.sh ...

I'm not sure if you still want this one or not after the other patch was
dropped. In any case Petr seems to favor command line args (with docs)
over env variables. So it would be best to stick to the existing style
of this script.

>
> Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
> ---
>  build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.sh b/build.sh
> index 1767cc21b..42c89ad97 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -18,7 +18,7 @@ CONFIGURE_OPTS_OUT_TREE="--with-realtime-testsuite $CONFIGURE_OPT_EXTRA"
>  SRC_DIR="$(cd $(dirname $0); pwd)"
>  BUILD_DIR="$SRC_DIR/../ltp-build"
>  
> -MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN)"
> +MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN) $MAKE_OPTS"
>  MAKE_OPTS_OUT_TREE="$MAKE_OPTS -C $BUILD_DIR -f $SRC_DIR/Makefile top_srcdir=$SRC_DIR top_builddir=$BUILD_DIR"
>  
>  run_configure()
> -- 
> 2.25.1


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp