From: Richard Palethorpe <rpalethorpe@suse.de>
To: Li Wang <liwang@redhat.com>
Cc: kernel-team <kernel-team@android.com>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2] fzsync: break inf loop with flag vs pthread_cancel
Date: Tue, 12 Apr 2022 10:40:57 +0100 [thread overview]
Message-ID: <87pmlmzl4q.fsf@suse.de> (raw)
In-Reply-To: <CAEemH2f+bDdbfLpK3Jtr_F4THvZHksmbYmV30o9zuz4nXH=xeA@mail.gmail.com>
Hello Edward and Li,
Li Wang <liwang@redhat.com> writes:
> On Mon, Apr 11, 2022 at 11:17 PM Edward Liaw via ltp <ltp@lists.linux.it> wrote:
>
> Hi, I'm working to get fzsync working with the Android kernel, which
> does not have pthread_cancel available.
>
> In the absence of pthread_cancel, when thread A exits due to a break,
> thread B will get stuck in an infinite loop while waiting for thread A
> to progress.
>
> Instead of cancelling thread B, we can use the exit flag to break out of
> thread B's loop. This should also remove the need for the wrapper
> around the thread.
>
> Signed-off-by: Edward Liaw <edliaw@google.com>
>
> Reviewed-by: Li Wang <liwang@redhat.com>
Awesome. Merged with some indentation fixes, it seems like you editor
used tab for the first indent then spaces thereafter.
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-04-12 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 15:16 [LTP] [PATCH v2] fzsync: break inf loop with flag vs pthread_cancel Edward Liaw via ltp
2022-04-12 2:40 ` Li Wang
2022-04-12 9:40 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmlmzl4q.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=kernel-team@android.com \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox