From: Richard Palethorpe <rpalethorpe@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 0/7] Remove scsi testsuite + various testscripts
Date: Wed, 18 Oct 2023 09:04:29 +0100 [thread overview]
Message-ID: <87r0lswdep.fsf@suse.de> (raw)
In-Reply-To: <20231016184408.879977-1-pvorel@suse.cz>
Hello,
Petr Vorel <pvorel@suse.cz> writes:
> Hi,
>
> cleanup of 2 old scsi testsuites and some of legacy testscripts.
> IMHO the testsuites are not worth of fixing.
Very good. My only suggestion is to leave a tombstone in the
documentation (or github issues) any time we delete something big and
the thing it was supposed to test still should be tested.
Something like "There was a testsuite called X, it appeared to do
Y, but we had to remove it because of Z".
It could be useful when answering questions about test feasability and
for SEO.
Reviwed-by: Richard Palethorpe <rpalethorpe@suse.com>
>
> Kind regards,
> Petr
>
> Petr Vorel (7):
> doc: Remove ltp-run-files.txt
> fs: Remove scsi/ltpfs testsuite
> fs: Remove scsi/ltpscsi testsuite
> testscripts: Remove ltpdmmapper.sh
> testscripts: Remove ltp-scsi_debug.sh
> testscripts: Remove sysfs.sh
> testcases: Remove autofs{1,4}.sh scripts
>
> doc/Test-Writing-Guidelines.asciidoc | 12 +
> doc/ltp-run-files.txt | 96 -
> testcases/kernel/fs/scsi/ltpfs/Ltpfs.h | 71 -
> testcases/kernel/fs/scsi/ltpfs/LtpfsCmds.c | 315 -
> testcases/kernel/fs/scsi/ltpfs/Makefile | 30 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part1 | 4 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part2 | 3 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part3 | 3 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part4 | 3 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part5 | 3 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part6 | 3 -
> testcases/kernel/fs/scsi/ltpfs/ltpfs.part7 | 3 -
> testcases/kernel/fs/scsi/ltpfs/ltpfsio.sh | 154 -
> testcases/kernel/fs/scsi/ltpfs/main.c | 647 --
> testcases/kernel/fs/scsi/ltpscsi/Makefile | 47 -
> testcases/kernel/fs/scsi/ltpscsi/llseek.c | 123 -
> testcases/kernel/fs/scsi/ltpscsi/llseek.h | 10 -
> testcases/kernel/fs/scsi/ltpscsi/ltpfsscsi.sh | 111 -
> testcases/kernel/fs/scsi/ltpscsi/scsimain.c | 7651 -----------------
> testcases/kernel/fs/scsi/ltpscsi/sg_err.c | 1379 ---
> testcases/kernel/fs/scsi/ltpscsi/sg_err.h | 162 -
> testcases/kernel/fs/scsi/ltpscsi/sg_include.h | 42 -
> testscripts/autofs1.sh | 273 -
> testscripts/autofs4.sh | 259 -
> testscripts/ltp-scsi_debug.sh | 218 -
> testscripts/ltpdmmapper.sh | 204 -
> testscripts/sysfs.sh | 121 -
> 27 files changed, 12 insertions(+), 11935 deletions(-)
> delete mode 100644 doc/ltp-run-files.txt
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/Ltpfs.h
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/LtpfsCmds.c
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/Makefile
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part1
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part2
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part3
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part4
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part5
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part6
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/ltpfs.part7
> delete mode 100755 testcases/kernel/fs/scsi/ltpfs/ltpfsio.sh
> delete mode 100644 testcases/kernel/fs/scsi/ltpfs/main.c
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/Makefile
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/llseek.c
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/llseek.h
> delete mode 100755 testcases/kernel/fs/scsi/ltpscsi/ltpfsscsi.sh
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/scsimain.c
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/sg_err.c
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/sg_err.h
> delete mode 100644 testcases/kernel/fs/scsi/ltpscsi/sg_include.h
> delete mode 100755 testscripts/autofs1.sh
> delete mode 100755 testscripts/autofs4.sh
> delete mode 100755 testscripts/ltp-scsi_debug.sh
> delete mode 100755 testscripts/ltpdmmapper.sh
> delete mode 100755 testscripts/sysfs.sh
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-18 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 18:44 [LTP] [RFC PATCH 0/7] Remove scsi testsuite + various testscripts Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 1/7] doc: Remove ltp-run-files.txt Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 2/7] fs: Remove scsi/ltpfs testsuite Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 3/7] fs: Remove scsi/ltpscsi testsuite Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 4/7] testscripts: Remove ltpdmmapper.sh Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 5/7] testscripts: Remove ltp-scsi_debug.sh Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 6/7] testscripts: Remove sysfs.sh Petr Vorel
2023-10-16 18:44 ` [LTP] [RFC PATCH 7/7] testcases: Remove autofs{1,4}.sh scripts Petr Vorel
2023-10-17 10:41 ` [LTP] [RFC PATCH 0/7] Remove scsi testsuite + various testscripts Marius Kittler
2023-10-17 15:07 ` Cyril Hrubis
2023-10-18 7:11 ` Li Wang
2023-10-18 8:04 ` Richard Palethorpe [this message]
2023-10-19 7:22 ` Petr Vorel
2023-10-19 7:34 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0lswdep.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox