From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 0/4] Auto review and Coccinelle
Date: Tue, 25 May 2021 15:03:58 +0100 [thread overview]
Message-ID: <87sg2akj01.fsf@suse.de> (raw)
In-Reply-To: <YKzp0rxGfaxL1blw@yuki>
Hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> Hi!
>> I'm not sure how to integrate it with the build system. We may just
>> want to do something similar to the kernel. Also I guess we want to
>> have a way of checking patches sent to the mailing list.
>
> I guess that having it in travis as a post commit check would be better
> than nothing.
>
> Pre commit hook would be ideal but requiring coccinelle installed for
> LTP development would increase the bar for contribution too much I
> guess.
I fear this defeats my primary goal of giving very quick feedback
without involving patch submission. This makes me think of clang-tidy
(clang-tools?) again. It will probably be more difficult to write LTP
specific checks, but I guess every desktop Linux distro less than 10
years old has Clang?
I don't think there is much else I can do than try writing the same
check in clang as well. See how that goes...
Anyway, we could copy the kernel to some extent. Make it so running
make coccicheck
or
make clang-tidy
or more generic
make check
Will recursively run the checks on the files under the current
directory?
--
Thank you,
Richard.
next prev parent reply other threads:[~2021-05-25 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 14:47 [LTP] [RFC PATCH 0/4] Auto review and Coccinelle Richard Palethorpe
2021-05-24 14:47 ` [LTP] [RFC PATCH 1/4] Add scripts to remove TEST in library Richard Palethorpe
2021-05-24 14:47 ` [LTP] [RFC PATCH 2/4] Add script to run Coccinelle checks Richard Palethorpe
2021-05-24 14:47 ` [LTP] [RFC PATCH 3/4] API: Mostly automatic removal of TEST() usage by Coccinelle Richard Palethorpe
2021-05-24 14:47 ` [LTP] [RFC PATCH 4/4] API: Removal of TST_ERR usage Richard Palethorpe
2021-05-25 12:13 ` [LTP] [RFC PATCH 0/4] Auto review and Coccinelle Cyril Hrubis
2021-05-25 14:03 ` Richard Palethorpe [this message]
2021-05-25 13:47 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg2akj01.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox