public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fs: exclude 'wakeup_count' from read_all_sys test.
Date: Fri, 10 Aug 2018 16:10:04 +0200	[thread overview]
Message-ID: <87sh3m48jn.fsf@rpws.prws.suse.cz> (raw)
In-Reply-To: <20180803152018.13701-1-sspatil@google.com>

Hello,

Sandeep Patil <sspatil@google.com> writes:

> /sys/power/wakeup_count semantics state that the read() for the file
> will block as long as there is a wakeup_event in progress. On most
> systems, this will be non deterministic and will result in extremely
> flaky test. Exclude the file from read_all_sys test for the same.
>
> Signed-off-by: Sandeep Patil <sspatil@google.com>
> ---
>  runtest/fs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runtest/fs b/runtest/fs
> index a66948a43..aca7e355f 100644
> --- a/runtest/fs
> +++ b/runtest/fs
> @@ -71,7 +71,7 @@ proc01 proc01 -m 128
>  
>  read_all_dev read_all -d /dev -p -q -r 10
>  read_all_proc read_all -d /proc -q -r 10
> -read_all_sys read_all -d /sys -q -r 10
> +read_all_sys read_all -d /sys -q -r 10 -e /sys/power/wakeup_count
>  

This probably won't be the only file with semantics like these. So I am
wondering if we can limit the time it spends blocking with timer_create
and SIGEV_THREAD_ID or something similar?

-- 
Thank you,
Richard.

  reply	other threads:[~2018-08-10 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 15:20 [LTP] [PATCH] fs: exclude 'wakeup_count' from read_all_sys test Sandeep Patil
2018-08-10 14:10 ` Richard Palethorpe [this message]
2018-08-13 15:02   ` Sandeep Patil
2018-08-14  7:48     ` Richard Palethorpe
2018-08-14 15:16       ` Cyril Hrubis
2018-08-20 16:06       ` Sandeep Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh3m48jn.fsf@rpws.prws.suse.cz \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox