From: Richard Palethorpe <rpalethorpe@suse.de>
To: Tarun Sahu <tsahu@linux.ibm.com>
Cc: aneesh.kumar@linux.ibm.com, ltp@lists.linux.it,
sbhat@linux.ibm.com, geetika@linux.ibm.com,
vaibhav@linux.ibm.com
Subject: Re: [LTP] [PATCH 7/8] Hugetlb: Migrating libhugetlbfs misalign
Date: Mon, 12 Dec 2022 14:32:09 +0000 [thread overview]
Message-ID: <87v8mgu1y8.fsf@suse.de> (raw)
In-Reply-To: <20221201122844.142062-8-tsahu@linux.ibm.com>
Tarun Sahu <tsahu@linux.ibm.com> writes:
> Migrating the libhugetlbfs/testcases/misalign.c test
>
> Test Description: Just as normal mmap()s can't have an address, length or
> offset which is not page aligned, so hugepage mmap()s can't have an
> address, length or offset with is not hugepage aligned.
>
> However, from time to time when the various mmap() /
> get_unmapped_area() paths are updated, somebody misses one of the
> necessary checks for the hugepage paths. This testcase ensures
> that attempted hugepage mappings with parameters which are not
> correctly hugepage aligned are rejected.
>
> However starting with 3.10-rc1, length passed in mmap() doesn't need
> to be aligned because 'commit af73e4d9506d
> ("hugetlbfs: fix mmap failure in unaligned size request")' added ALIGN()
> to kernel side, in mmap_pgoff(), when mapping huge page files.
>
> Signed-off-by: Tarun Sahu <tsahu@linux.ibm.com>
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-12-12 14:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 12:28 [LTP] [PATCH 0/8][PART 3] Hugetlb:Migrating the libhugetlbfs tests Tarun Sahu
2022-12-01 12:28 ` [LTP] [PATCH 1/8] Hugetlb: Migrating libhugetlbfs fork-cow Tarun Sahu
2022-12-05 12:28 ` Richard Palethorpe
2022-12-07 12:47 ` Tarun Sahu
2022-12-08 8:54 ` Richard Palethorpe
2022-12-01 12:28 ` [LTP] [PATCH 2/8] Hugetlb: Migrating libhugetlbfs huge_at_4GB_normal_below Tarun Sahu
2022-12-05 13:32 ` Richard Palethorpe
2022-12-07 12:54 ` Tarun Sahu
2022-12-01 12:28 ` [LTP] [PATCH 3/8] Hugetlb: Migrating libhugetlbfs huge_below_4GB_normal_above Tarun Sahu
2022-12-06 8:57 ` Richard Palethorpe
2022-12-07 12:51 ` Tarun Sahu
2022-12-01 12:28 ` [LTP] [PATCH 4/8] Hugetlb: Migrating libhugetlbfs icache-hygiene Tarun Sahu
2022-12-12 14:08 ` Richard Palethorpe
2022-12-13 17:27 ` Tarun Sahu
2022-12-19 21:01 ` Tarun Sahu
2022-12-01 12:28 ` [LTP] [PATCH 5/8] Hugetlb: Migrating libhugetlbfs madvise_reserve Tarun Sahu
2022-12-12 14:22 ` Richard Palethorpe
2022-12-01 12:28 ` [LTP] [PATCH 6/8] Hugetlb: Migrating libhugetlbfs map_high_truncate_2 Tarun Sahu
2022-12-12 14:26 ` Richard Palethorpe
2022-12-01 12:28 ` [LTP] [PATCH 7/8] Hugetlb: Migrating libhugetlbfs misalign Tarun Sahu
2022-12-12 14:32 ` Richard Palethorpe [this message]
2022-12-01 12:28 ` [LTP] [PATCH 8/8] Hugetlb: Migrating libhugetlbfs misaligned_offset Tarun Sahu
2022-12-12 14:33 ` Richard Palethorpe
2022-12-12 14:50 ` [LTP] [PATCH 0/8][PART 3] Hugetlb:Migrating the libhugetlbfs tests Richard Palethorpe
2022-12-13 5:00 ` Tarun Sahu
-- strict thread matches above, loose matches on Subject: below --
2022-11-20 19:15 [LTP] [PATCH v5 0/7][PART 2] " Tarun Sahu
2022-12-01 12:02 ` [LTP] [PATCH 0/8][PART 3] " Tarun Sahu
2022-12-01 12:02 ` [LTP] [PATCH 7/8] Hugetlb: Migrating libhugetlbfs misalign Tarun Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8mgu1y8.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=aneesh.kumar@linux.ibm.com \
--cc=geetika@linux.ibm.com \
--cc=ltp@lists.linux.it \
--cc=sbhat@linux.ibm.com \
--cc=tsahu@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox