Re: [LTP] [PATCH 3/8] Hugetlb: Migrating libhugetlbfs huge_below_4GB_normal_above

Tarun Sahu
2022-12-07T12:51:52Z

Hi,

Thanks for reviewing it.

On Dec 06 2022, Richard Palethorpe wrote:
> Hello,
>
> Tarun Sahu <tsahu@linux.ibm.com> writes:
>
> > Migrating the libhugetlbfs/testcases/huge_below_4GB_normal_above.c test
> >
> > Test Description: Designed to pick up a bug on ppc64 where
> > touches_hugepage_low_range() could give false positives because of the
> > peculiar (undefined) behaviour of << for large shifts
> >
> > Signed-off-by: Tarun Sahu <tsahu@linux.ibm.com>
> > + *
> > + * Designed to pick up a bug on ppc64 where touches_hugepage_low_range()
> > + * could give false positives because of the peculiar (undefined)
> > + * behaviour of << for large shifts
> > + *
> > + * WARNING: The offsets and addresses used within are specifically
> > + * calculated to trigger the bug as it existed. Don't mess with them
> > + * unless you *really* know what you're doing.
>
> I guess the test is good insofar that I can tell. As with hugemmap13 it
> would be nice to have a reference to the bugfix though.
>
> > +
> > +static struct tst_test test = {
> > + .needs_root = 1,
> > + .mntpoint = MNTPOINT,
> > + .needs_hugetlbfs = 1,
> > + .needs_tmpdir = 1,
> > + .setup = setup,
> > + .cleanup = cleanup,
> > + .test_all = run_test,
> > + .hugepages = {2, TST_NEEDS},
>
> If we can find the bugfix commit then it can be referenced in the tags
> here.
>
Yeah, Will update the bug-fix references in v2
> --
> Thank you,
> Richard.
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp