public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>,
	Alessandro Carminati <alessandro.carminati@gmail.com>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] lib/tst_device: Remove unused count_match_len()
Date: Mon, 14 Nov 2022 10:23:41 +0000	[thread overview]
Message-ID: <87wn7xu93o.fsf@suse.de> (raw)
In-Reply-To: <20221110175236.32094-2-pvorel@suse.cz>

Hello,

Petr Vorel <pvorel@suse.cz> writes:

> Fixes: e1b1ae66b ("tst_find_backing_dev: Get dev name from /sys/dev/block/*/uevent")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Yup, my mistake.

Acked-by: Richard Palethorpe <rpalethorpe@suse.com>


> ---
> Hi,
>
> obviously correct, but not merging it without ack there are changes and
> function is actually needed.
>
> Kind regards,
> Petr
>
>  lib/tst_device.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/lib/tst_device.c b/lib/tst_device.c
> index db5c2ab8f..48d7e3ab6 100644
> --- a/lib/tst_device.c
> +++ b/lib/tst_device.c
> @@ -510,16 +510,6 @@ unsigned long tst_dev_bytes_written(const char *dev)
>  	return dev_bytes_written;
>  }
>  
> -static int count_match_len(const char *first, const char *second)
> -{
> -	int len = 0;
> -
> -	while (*first && *first++ == *second++)
> -		len++;
> -
> -	return len;
> -}
> -
>  __attribute__((nonnull))
>  void tst_find_backing_dev(const char *path, char *dev)
>  {


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-11-14 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 17:52 [LTP] [PATCH 0/2] tst_find_backing_dev() fixes Petr Vorel
2022-11-10 17:52 ` [LTP] [PATCH 1/2] lib/tst_device: Remove unused count_match_len() Petr Vorel
2022-11-14 10:23   ` Richard Palethorpe [this message]
2022-11-10 17:52 ` [LTP] [PATCH 2/2] doc/c-test-api.txt: Improve tst_find_backing_dev() doc Petr Vorel
2022-11-14 10:25   ` Richard Palethorpe
2022-11-14 15:09     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn7xu93o.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=alessandro.carminati@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    --cc=xuyang2018.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox