public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Zhao Gongyi <zhaogongyi@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: Move setup_ipc() to the beginning of do_setup()
Date: Thu, 20 Oct 2022 09:58:06 +0100	[thread overview]
Message-ID: <87wn8uvpcf.fsf@suse.de> (raw)
In-Reply-To: <20221010081628.37168-1-zhaogongyi@huawei.com>

Hello,

Zhao Gongyi via ltp <ltp@lists.linux.it> writes:

> Move setup_ipc() to the beginning of do_setup() since we
> would use the 'results' immediately in do_setup(), otherwise,there
> is no Results statistics when calling the tst_brk in do_setup().
>
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
>  lib/tst_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 8ccde1629..02fc6a06e 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -1096,6 +1096,8 @@ static void do_cgroup_requires(void)
>
>  static void do_setup(int argc, char *argv[])
>  {
> +	setup_ipc();
> +

We can't move it to before checking if tst_test is null.

Is there anything else that needs to be done before calling that?

-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-10-20  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  8:16 [LTP] [PATCH] lib: Move setup_ipc() to the beginning of do_setup() Zhao Gongyi via ltp
2022-10-20  8:58 ` Richard Palethorpe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-10-20 11:58 zhaogongyi via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn8uvpcf.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    --cc=zhaogongyi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox