From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Palethorpe Date: Tue, 06 Jul 2021 10:45:56 +0100 Subject: [LTP] [PATCH 0/1] fs_bind: Convert to ltp tests In-Reply-To: <20210705135014.679200-1-lkml@jv-coder.de> References: <20210705135014.679200-1-lkml@jv-coder.de> Message-ID: <87wnq37p2j.fsf@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hello Joerg, Joerg Vehlow writes: > Hi everyone, > > I know this is a huge changeset, but there is not really a good way to > break it down into multiple commits. Every step in between would either > lead to a broken test suite or a change, that is then changed again. > So I made this one huge commit, that converts all of the tests of the > testsuite in one go. It seems like there are no file renames (according to Git), but many files are deleted and created. So you could split the commit into a deletion patch and a creation patch. I guess the deletion patch might have to remove some runtest file entries temporarily? However I don't see a big problem with that. > > I added some minor bugfixes especially added umounts, because some where > missing and some were redundant. I also dropped all useless output (bare ls). > > I may have overused EXPECT_PASS a bit here, but I think it does not do any harm, > if all mounts are checked. > > Joerg -- Thank you, Richard.