public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] mem: ksm: fix volatile page false positive
Date: Tue, 12 Sep 2017 10:11:32 +0200	[thread overview]
Message-ID: <87wp54z68b.fsf@our.domain.is.not.set> (raw)
In-Reply-To: <20170825083427.25745-2-aarcange@redhat.com>

Hello,

Andrea Arcangeli writes:

> +	/*
> +	 * The current scan is already in progress so we wouldn't
> +	 * guarantee to call get_user_pages() on every existing
> +	 * rmap_item if we only waited the remaining part of the
> +	 * current scan.

Only a minor nit, but the wording is a bit unnatural here, it should
probably be: "... in progress so we can't guarantee that
get_user_pages() is is called on every existing rmap_item if ..."

> +	 *
> +	 * The actual merging happens after the unstable tree has been
> +	 * built so we need to wait at least two full scans to
> +	 * guarantee merging, so wait full_scans to increment by 3 so
> +	 * at least two full scans will run.
> +	 */

--
Thank you,
Richard.

  reply	other threads:[~2017-09-12  8:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  8:34 [LTP] [PATCH 0/2] mem: ksm: race condition fixes Andrea Arcangeli
2017-08-25  8:34 ` [LTP] [PATCH 1/2] mem: ksm: fix volatile page false positive Andrea Arcangeli
2017-09-12  8:11   ` Richard Palethorpe [this message]
2017-09-13 11:58   ` Cyril Hrubis
2017-09-13 13:47     ` Andrea Arcangeli
2017-08-25  8:34 ` [LTP] [PATCH 2/2] mem: ksm: fixes for race conditions Andrea Arcangeli
2017-09-13  7:46   ` Richard Palethorpe
2017-09-05  2:22 ` [LTP] [PATCH 0/2] mem: ksm: race condition fixes Bhupesh Sharma
  -- strict thread matches above, loose matches on Subject: below --
2017-08-24 17:54 Andrea Arcangeli
2017-08-24 17:54 ` [LTP] [PATCH 1/2] mem: ksm: fix volatile page false positive Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp54z68b.fsf@our.domain.is.not.set \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox