[LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Marius Kittler]

Otherwise clone303 fails with TBROK when `/sys/fs/cgroup` is mounted as
read-only which is normal in a container. The test result should better
be TCONF like it is already done in case of a permission error.

Signed-off-by: Marius Kittler <mkittler@suse.de>
---
 lib/tst_cgroup.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
index fdeac6059..5240aadaa 100644
--- a/lib/tst_cgroup.c
+++ b/lib/tst_cgroup.c
@@ -383,6 +383,9 @@ static void cgroup_dir_mk(const struct cgroup_dir *const parent,
 		tst_brk(TCONF | TERRNO,
 			"Lack permission to make '%s/%s'; premake it or run as root",
 			dpath, dir_name);
+	} else if (errno == EROFS) {
+		tst_brk(TCONF | TERRNO, "'%s/%s' must not be read-only",
+			dpath, dir_name);
 	} else {
 		tst_brk(TBROK | TERRNO,
 			"mkdirat(%d<%s>, '%s', 0777)",
-- 
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Petr Vorel]

Hi all,

> Otherwise clone303 fails with TBROK when `/sys/fs/cgroup` is mounted as
> read-only which is normal in a container. The test result should better
> be TCONF like it is already done in case of a permission error.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

IMHO another candidate for merging before release.

Kind regards,
Petr

> Signed-off-by: Marius Kittler <mkittler@suse.de>
> ---
>  lib/tst_cgroup.c | 3 +++
>  1 file changed, 3 insertions(+)

> diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
> index fdeac6059..5240aadaa 100644
> --- a/lib/tst_cgroup.c
> +++ b/lib/tst_cgroup.c
> @@ -383,6 +383,9 @@ static void cgroup_dir_mk(const struct cgroup_dir *const parent,
>  		tst_brk(TCONF | TERRNO,
>  			"Lack permission to make '%s/%s'; premake it or run as root",
>  			dpath, dir_name);
> +	} else if (errno == EROFS) {
> +		tst_brk(TCONF | TERRNO, "'%s/%s' must not be read-only",
> +			dpath, dir_name);
>  	} else {
>  		tst_brk(TBROK | TERRNO,
>  			"mkdirat(%d<%s>, '%s', 0777)",

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Wei Gao via ltp]

On Mon, Sep 25, 2023 at 05:17:28PM +0200, Petr Vorel wrote:
> Hi all,
> 
> > Otherwise clone303 fails with TBROK when `/sys/fs/cgroup` is mounted as
> > read-only which is normal in a container. The test result should better
> > be TCONF like it is already done in case of a permission error.
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
  Tested-by: Wei Gao <wegao@suse.com>
> 
> IMHO another candidate for merging before release.
> 
> Kind regards,
> Petr
> 
> > Signed-off-by: Marius Kittler <mkittler@suse.de>
> > ---
> >  lib/tst_cgroup.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> > diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
> > index fdeac6059..5240aadaa 100644
> > --- a/lib/tst_cgroup.c
> > +++ b/lib/tst_cgroup.c
> > @@ -383,6 +383,9 @@ static void cgroup_dir_mk(const struct cgroup_dir *const parent,
> >  		tst_brk(TCONF | TERRNO,
> >  			"Lack permission to make '%s/%s'; premake it or run as root",
> >  			dpath, dir_name);
> > +	} else if (errno == EROFS) {
> > +		tst_brk(TCONF | TERRNO, "'%s/%s' must not be read-only",
> > +			dpath, dir_name);
> >  	} else {
> >  		tst_brk(TBROK | TERRNO,
> >  			"mkdirat(%d<%s>, '%s', 0777)",
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Petr Vorel]

Hi,

...
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
>   Tested-by: Wei Gao <wegao@suse.com>
    ^
	Unwanted whitespace before the tag.

Wei, please don't put this whitespace space next time.

Not only this is wrong, but it breaks automatic adding of your tag.
Patchwork (https://patchwork.ozlabs.org/project/ltp/list/) which we use for
downloading patches automatically adds all tags associated with the patch,
unless there is whitespace before the tag.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Wei Gao via ltp]

On Wed, Sep 27, 2023 at 07:52:21AM +0200, Petr Vorel wrote:
> Hi,
> 
> ...
> > > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> >   Tested-by: Wei Gao <wegao@suse.com>
>     ^
> 	Unwanted whitespace before the tag.
> 
> Wei, please don't put this whitespace space next time.
> 
> Not only this is wrong, but it breaks automatic adding of your tag.
> Patchwork (https://patchwork.ozlabs.org/project/ltp/list/) which we use for
> downloading patches automatically adds all tags associated with the patch,
> unless there is whitespace before the tag.
Got it. Thanks for correcting the error.
> 
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Richard Palethorpe]

Hello,

Marius Kittler <mkittler@suse.de> writes:

> Otherwise clone303 fails with TBROK when `/sys/fs/cgroup` is mounted as
> read-only which is normal in a container. The test result should better
> be TCONF like it is already done in case of a permission error.
>
> Signed-off-by: Marius Kittler <mkittler@suse.de>

Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>

> ---
>  lib/tst_cgroup.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
> index fdeac6059..5240aadaa 100644
> --- a/lib/tst_cgroup.c
> +++ b/lib/tst_cgroup.c
> @@ -383,6 +383,9 @@ static void cgroup_dir_mk(const struct cgroup_dir *const parent,
>  		tst_brk(TCONF | TERRNO,
>  			"Lack permission to make '%s/%s'; premake it or run as root",
>  			dpath, dir_name);
> +	} else if (errno == EROFS) {
> +		tst_brk(TCONF | TERRNO, "'%s/%s' must not be read-only",
> +			dpath, dir_name);
>  	} else {
>  		tst_brk(TBROK | TERRNO,
>  			"mkdirat(%d<%s>, '%s', 0777)",
> -- 
> 2.42.0


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Skip cgroup-related tests if `/sys/fs/cgroup` readonly

[Petr Vorel]

Hi Richie, Wei,

thanks for your review/testing, merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp