From: Richard Palethorpe <rpalethorpe@suse.de>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/9] Rewrite rename01.c using new LTP API
Date: Wed, 13 Jul 2022 06:30:54 +0100 [thread overview]
Message-ID: <87y1wxmvas.fsf@suse.de> (raw)
In-Reply-To: <20220712153417.14551-2-akumar@suse.de>
Hello,
Avinesh Kumar <akumar@suse.de> writes:
> +static inline void swap(const char **a, const char **b)
> +{
> + const char *tmp__ = *a;
> + *a = *b;
> + *b = tmp__;
> +}
We don't need the trailing underscores, but I can fix this up before
merging so no need to resubmit.
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-07-13 5:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 15:34 [LTP] [PATCH v3 0/9] Simplify and convert some of rename tests to new LTP API Avinesh Kumar
2022-07-12 15:34 ` [LTP] [PATCH v3 1/9] Rewrite rename01.c using " Avinesh Kumar
2022-07-13 5:30 ` Richard Palethorpe [this message]
2022-07-12 15:34 ` [LTP] [PATCH v3 2/9] Remove rename02.c Avinesh Kumar
2022-07-13 5:33 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 3/9] Rewrite rename03.c using new LTP API Avinesh Kumar
2022-07-13 5:35 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 4/9] Rewrite rename04.c " Avinesh Kumar
2022-07-13 5:36 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 5/9] Rewrite rename05.c " Avinesh Kumar
2022-07-13 5:42 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 6/9] Rewrite rename06.c " Avinesh Kumar
2022-07-13 5:43 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 7/9] Rewrite rename07.c " Avinesh Kumar
2022-07-13 5:43 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 8/9] Rewrite rename08.c " Avinesh Kumar
2022-07-13 5:47 ` Richard Palethorpe
2022-07-12 15:34 ` [LTP] [PATCH v3 9/9] Rewrite rename10.c " Avinesh Kumar
2022-07-13 5:48 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1wxmvas.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox