Re: [LTP] [PATCH 2/3] openposix: Setup autoconf and fix installation layout

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello Joerg,

Joerg Vehlow <lkml@jv-coder.de> writes:

> Hi Richard,
>
> Am 7/5/2022 um 8:28 AM schrieb Richard Palethorpe:
>> 
>> Richard Palethorpe <rpalethorpe@suse.de> writes:
>> 
>>> Hello Joerg,
>>>
>>> Joerg Vehlow <lkml@jv-coder.de> writes:
>>>
>>>> From: Joerg Vehlow <joerg.vehlow@aox.de>
>>>>
>>>> This allows installation of the tests to a different directory
>>>> than directly under $prefix.
>>>>
>>>> Before the layout was:
>>>> $prefix/bin/{run-*,t0,run-tests.h,Makefile}
>>>> $prefix/conformance
>>>> $prefix/functional
>>>> $prefix/stress
>>>>
>>>> with prefix being /opt/openposix_testsuite on linux and
>>>> /usr/local/openposix_testsuite on other systems
>>>> OR the value of the env-var $prefix.
>>>>
>>>> With this change, the prefix defaults to /opt/openposix_testsuite
>>>> and can be changed the usual way using configure (./configure ---prefix=foo)
>>>> Additionally the path of the tests below $prefix can be changed, using
>>>> configure --with-open-posix-testdir=<foo>. This allows clean installation as
>>>> part of ltp:
>>>>
>>>> $prefix/bin/{run-all-posix-option-group-tests.sh,run-posix-option-group-test.sh}
>>>> $prefix/$testdir/bin/{run-tests.sh,t0}
>>>> $prefix/$testdir/conformance
>>>> $prefix/$testdir/functional
>>>> $prefix/$testdir/stress
>> 
>> Sorry I don't see the need for this. I can't find the RFC where you may
>> have explained it, however it should be written here anyway I think.
>
> here is the RFC in the mailing list archive:
> https://lists.linux.it/pipermail/ltp/2022-June/029188.html
>
> Joerg

OK, so things are being installed twice and it is generally a
mess. This looks like a good cleanup.

However this really needs to be explained in the patchset. There
needs to be a clear description of where things have moved from and
to. In particular what someone needs to do if this breaks their test
runner scripts. This can then be copied into the LTP release notes.

BTW IIRC we generate runtest files for the open posix tests and the test
runner handles them almost like normal LTP tests. We don't use any of
those scripts either.

-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp